[Java.Interop] RegisterNatives() shouldn't exceed numMethods #1029
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: dotnet/android#7285 (comment)
Java.Inteorp.JniEnvironment.Types.RegisterNatives()
is overloaded:If the
int numMethods
overload is used, then:numMethods
elements, andFor example:
Instead, when using a Debug configuration build of
Java.Interop.dll
,a
NullReferenceException
would be thrown, because theforeach
loop would traverse every element, not just the first
numMethods
elements, which could result in accessing
methods[i].Marshaler.GetType()
, which could benull
.Fix the
DEBUG && NETCOREAPP
check so that only the firstnumMethods
elements are accessed, not all of them, and add anull
check aroundJniNativeMethodRegistration.Marshaler
access.This prevents the
NullReferenceException
.