-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Localization] Import translated resx files #1018
Conversation
…2: Build ID 6443469
…2: Build ID 6481287
…2: Build ID 6487189
…2: Build ID 6492007
Looking at the latest loc state report in https://msit.powerbi.com/groups/me/reports/506828e8-e70a-4e08-a50a-a3acf24fd3f4/ReportSectionf349dc6f5320b0d67634 (search for java.interop in the "Repo Name" box on the left), it appears that these files are now fully translated. I checked a local build of this branch, and can see translated strings in Java.Interop.Localization.Resources files as well: We should be ready to merge this one. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes here seem ok.
For my understanding, are these used along with exception messages in Java.Interop.dll
? Do we need to worry about app sizes growing?
I believe we only distribute these files as part of our SDK, so I don't think any changes to the sizes of those satellite assemblies would impact customer apps. |
Ok, so you'd only see these messages from an MSBuild error, sounds good. |
The Java.Interop repo has been fully onboarded into the OneLoc system,
and the translations for Java.Interop.Localization are now complete.
XLF files and the XliffTasks NuGet will no longer be used. They have
been replaced by the OneLocBuild translation process which produces
translated RESX files.
Future changes to
src/Java.Interop.Localization/Resources.resx
willtrigger a new OneLocBuild handoff for translation. Shortly after that,
the LCL files in the Localize folder will be automatically updated with
newly translated strings. This update will cause the OneLocBuild task
to open another PR which updates the RESX files used to produce
localized satellite assemblies.
This is the pull request automatically created by the OneLocBuild task
in the build process to check-in localized files generated based upon
translation source files (.lcl files) handed-back from the downstream
localization pipeline. If there are issues in translations, visit
https://aka.ms/ceLocBug and log bugs for fixes. The OneLocBuild wiki is
https://aka.ms/onelocbuild and the localization process in general is
documented at https://aka.ms/AllAboutLoc.