Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Localization] Import translated resx files #1018

Merged
merged 6 commits into from
Aug 5, 2022

Conversation

vs-mobiletools-engineering-service2
Copy link
Collaborator

@vs-mobiletools-engineering-service2 vs-mobiletools-engineering-service2 commented Jul 20, 2022

The Java.Interop repo has been fully onboarded into the OneLoc system,
and the translations for Java.Interop.Localization are now complete.

XLF files and the XliffTasks NuGet will no longer be used. They have
been replaced by the OneLocBuild translation process which produces
translated RESX files.

Future changes to src/Java.Interop.Localization/Resources.resx will
trigger a new OneLocBuild handoff for translation. Shortly after that,
the LCL files in the Localize folder will be automatically updated with
newly translated strings. This update will cause the OneLocBuild task
to open another PR which updates the RESX files used to produce
localized satellite assemblies.


This is the pull request automatically created by the OneLocBuild task
in the build process to check-in localized files generated based upon
translation source files (.lcl files) handed-back from the downstream
localization pipeline. If there are issues in translations, visit
https://aka.ms/ceLocBug and log bugs for fixes. The OneLocBuild wiki is
https://aka.ms/onelocbuild and the localization process in general is
documented at https://aka.ms/AllAboutLoc.

@pjcollins pjcollins self-assigned this Jul 20, 2022
@pjcollins pjcollins marked this pull request as draft July 20, 2022 22:26
@vs-mobiletools-engineering-service2 vs-mobiletools-engineering-service2 changed the title Localized file check-in by OneLocBuild Task: Build definition ID 12262: Build ID 6443469 Localized file check-in by OneLocBuild Task: Build definition ID 12262: Build ID 6443572 Jul 20, 2022
@vs-mobiletools-engineering-service2 vs-mobiletools-engineering-service2 changed the title Localized file check-in by OneLocBuild Task: Build definition ID 12262: Build ID 6443572 Localized file check-in by OneLocBuild Task: Build definition ID 12262: Build ID 6464854 Jul 25, 2022
@vs-mobiletools-engineering-service2 vs-mobiletools-engineering-service2 changed the title Localized file check-in by OneLocBuild Task: Build definition ID 12262: Build ID 6464854 Localized file check-in by OneLocBuild Task: Build definition ID 12262: Build ID 6481287 Jul 28, 2022
@vs-mobiletools-engineering-service2 vs-mobiletools-engineering-service2 changed the title Localized file check-in by OneLocBuild Task: Build definition ID 12262: Build ID 6481287 Localized file check-in by OneLocBuild Task: Build definition ID 12262: Build ID 6487189 Jul 29, 2022
@vs-mobiletools-engineering-service2 vs-mobiletools-engineering-service2 changed the title Localized file check-in by OneLocBuild Task: Build definition ID 12262: Build ID 6487189 Localized file check-in by OneLocBuild Task: Build definition ID 12262: Build ID 6492007 Jul 30, 2022
@vs-mobiletools-engineering-service2 vs-mobiletools-engineering-service2 changed the title Localized file check-in by OneLocBuild Task: Build definition ID 12262: Build ID 6492007 Localized file check-in by OneLocBuild Task: Build definition ID 12262: Build ID 6502104 Aug 2, 2022
@pjcollins
Copy link
Member

Looking at the latest loc state report in https://msit.powerbi.com/groups/me/reports/506828e8-e70a-4e08-a50a-a3acf24fd3f4/ReportSectionf349dc6f5320b0d67634 (search for java.interop in the "Repo Name" box on the left), it appears that these files are now fully translated. I checked a local build of this branch, and can see translated strings in Java.Interop.Localization.Resources files as well:
image

We should be ready to merge this one.

@pjcollins pjcollins changed the title Localized file check-in by OneLocBuild Task: Build definition ID 12262: Build ID 6502104 [Localization] Import translated resx files Aug 3, 2022
@pjcollins pjcollins marked this pull request as ready for review August 3, 2022 18:30
Copy link
Member

@jonathanpeppers jonathanpeppers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes here seem ok.

For my understanding, are these used along with exception messages in Java.Interop.dll? Do we need to worry about app sizes growing?

@pjcollins
Copy link
Member

For my understanding, are these used along with exception messages in Java.Interop.dll? Do we need to worry about app sizes growing?

I believe we only distribute these files as part of our SDK, so I don't think any changes to the sizes of those satellite assemblies would impact customer apps.

@jonathanpeppers
Copy link
Member

Ok, so you'd only see these messages from an MSBuild error, sounds good.

@pjcollins pjcollins requested a review from dellis1972 August 4, 2022 16:40
@pjcollins pjcollins merged commit 9b1d3ab into main Aug 5, 2022
@pjcollins pjcollins deleted the locpr/b198030a-7cc2-4c69-a03e-39664cf83f57 branch August 5, 2022 18:43
@github-actions github-actions bot locked and limited conversation to collaborators Apr 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants