Completion and input API improvements #3727
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonsequitur
force-pushed
the
api-improvements-10-22-2024
branch
from
4e70fb4 to
2e48bb6
Compare
colombod
approved these changes
Oct 23, 2024
colombod
approved these changes
Oct 24, 2024
jonsequitur
force-pushed
the
api-improvements-10-22-2024
branch
from
90471dc to
3c0671d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes the following API improvements:
KernelDirectiveParameter.AddCompletionsto remove an overload and make usage clearer, e.g. completion values are either returned as a sequence ofstring(in the simple case) or added to theKernelDirectiveCompletionContext(in the more complex case.) Only the latter has access to theKernelCompletionContextand only the latter isasync.CompositeKernel.AddKernelConnectortoAddConnectDirectiveto better align with new API names.Kernel.GetInputsAsyncto support programmatic use of form inputs.