Fix issues with stored SQL or KQL queries not showing in variable explorer #2995
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
17 tasks
jonsequitur
reviewed
May 22, 2023
src/Microsoft.DotNet.Interactive.Kql.Tests/KqlConnectionTests.cs
Outdated
Show resolved
Hide resolved
jonsequitur
reviewed
May 22, 2023
| @@ -336,6 +334,30 @@ public async Task It_can_store_result_set_with_a_name() | |||
| .Be(1); | |||
| } | |||
|
|
|||
| [MsSqlFact] | |||
| public async Task Stored_query_results_are_listed_in_requestValueInfos() | |||
There was a problem hiding this comment.
Same rename suggestion.
jonsequitur
reviewed
May 22, 2023
| @@ -374,7 +374,7 @@ Task IKernelCommandHandler<RequestValueInfos>.HandleAsync(RequestValueInfos comm | |||
| var valueInfos = QueryResults.Keys.Select(key => | |||
| { | |||
| var formattedValues = FormattedValue.CreateSingleFromObject( | |||
| _variables[key], | |||
| QueryResults[key], | |||
There was a problem hiding this comment.
Do we need to be storing these in separate buckets?
There was a problem hiding this comment.
changed my mind : yes should be one, merged that behaviour
jonsequitur
reviewed
May 22, 2023
| @@ -260,7 +260,7 @@ Microsoft.DotNet.Interactive.SqlServer | |||
| protected System.Boolean CanDeclareVariable(System.String name, System.Object value, ref System.String& msg) | |||
| public System.Threading.Tasks.Task ConnectAsync() | |||
| protected System.String CreateVariableDeclaration(System.String name, System.Object value) | |||
| protected System.Collections.Generic.Dictionary<System.String,System.Collections.Generic.IReadOnlyCollection<Microsoft.DotNet.Interactive.Formatting.TabularData.TabularDataResource>> get_QueryResults() | |||
| protected System.Collections.Generic.Dictionary<System.String,System.Object> get_Variables() | |||
There was a problem hiding this comment.
Exposing these as dictionaries mean they can be directly updated programmatically, bypassing other ways of declaring a variable. I'm not sure we want that.
There was a problem hiding this comment.
good point, removed access and added a StoreQueryResult method (protected)
| @@ -345,7 +335,7 @@ async Task IKernelCommandHandler<RequestCompletions>.HandleAsync(RequestCompleti | |||
|
|
|||
| public bool TryGetValue<T>(string name, out T value) | |||
| { | |||
| if (QueryResults.TryGetValue(name, out var resultSet) && | |||
| if (_variables.TryGetValue(name, out var resultSet) && | |||
There was a problem hiding this comment.
Ah was the bug basically that we (inadvertently) used the wrong dictionary?
improve test Update src/Microsoft.DotNet.Interactive.Kql.Tests/KqlConnectionTests.cs Co-authored-by: Jon Sequeira <[email protected]> pr feedback collapse variables and query results update contracts api remove access to the dictionary changes rename api
colombod
force-pushed
the
variable_explorer
branch
from
ff95806 to
2edfdd6
Compare
shyamnamboodiripad
approved these changes
May 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses issue #2902