Update source-build artifacts to be coherent #15372

MichaelSimons · 2023-01-30T21:57:41Z

No description provided.

MichaelSimons · 2023-01-31T21:44:42Z

@ViktorHofer - Are you aware of any runtime changes that might be causing the following errors? I am trying to update the SDK to eliminate some prebuilts and the build was working for me on commit 007df054a526ed9e3dc70b43bfa330943bd4816a but started failing after dfe1076090adad6990747e6abed8bf6699371877 flowed in. TIA

    CSC : warning CS8784: Generator 'LibraryImportGenerator' failed to initialize. It will not contribute to the output and compilation errors may occur as a result. Exception was of type 'FileNotFoundException' with message 'Could not load file or assembly 'Microsoft.Interop.SourceGeneration, Version=8.0.8.8002, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a'. The system cannot find the path specified. [/vmr/src/runtime/artifacts/source-build/self/src/src/tasks/AndroidAppBuilder/AndroidAppBuilder.csproj]
    CSC : warning CS8784: Generator 'LibraryImportGenerator' failed to initialize. It will not contribute to the output and compilation errors may occur as a result. Exception was of type 'FileNotFoundException' with message 'Could not load file or assembly 'Microsoft.Interop.SourceGeneration, Version=8.0.8.8002, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a'. The system cannot find the path specified. [/vmr/src/runtime/artifacts/source-build/self/src/src/tasks/AotCompilerTask/MonoAOTCompiler.csproj::TargetFramework=net8.0]
    CSC : warning CS8784: Generator 'LibraryImportGenerator' failed to initialize. It will not contribute to the output and compilation errors may occur as a result. Exception was of type 'FileNotFoundException' with message 'Could not load file or assembly 'Microsoft.Interop.SourceGeneration, Version=8.0.8.8002, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a'. The system cannot find the path specified. [/vmr/src/runtime/artifacts/source-build/self/src/src/tasks/AppleAppBuilder/AppleAppBuilder.csproj]
    CSC : warning CS8784: Generator 'LibraryImportGenerator' failed to initialize. It will not contribute to the output and compilation errors may occur as a result. Exception was of type 'FileNotFoundException' with message 'Could not load file or assembly 'Microsoft.Interop.SourceGeneration, Version=8.0.8.8002, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a'. The system cannot find the path specified. [/vmr/src/runtime/artifacts/source-build/self/src/src/tasks/Crossgen2Tasks/Crossgen2Tasks.csproj]
    CSC : warning CS8784: Generator 'LibraryImportGenerator' failed to initialize. It will not contribute to the output and compilation errors may occur as a result. Exception was of type 'FileNotFoundException' with message 'Could not load file or assembly 'Microsoft.Interop.SourceGeneration, Version=8.0.8.8002, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a'. The system cannot find the path specified. [/vmr/src/runtime/artifacts/source-build/self/src/src/tasks/installer.tasks/installer.tasks.csproj::TargetFramework=net8.0]
    CSC : warning CS8784: Generator 'LibraryImportGenerator' failed to initialize. It will not contribute to the output and compilation errors may occur as a result. Exception was of type 'FileNotFoundException' with message 'Could not load file or assembly 'Microsoft.Interop.SourceGeneration, Version=8.0.8.8002, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a'. The system cannot find the path specified. [/vmr/src/runtime/artifacts/source-build/self/src/src/tasks/TestExclusionListTasks/TestExclusionListTasks.csproj]
    CSC : warning CS8784: Generator 'LibraryImportGenerator' failed to initialize. It will not contribute to the output and compilation errors may occur as a result. Exception was of type 'FileNotFoundException' with message 'Could not load file or assembly 'Microsoft.Interop.SourceGeneration, Version=8.0.8.8002, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a'. The system cannot find the path specified. [/vmr/src/runtime/artifacts/source-build/self/src/src/libraries/Microsoft.NET.WebAssembly.Webcil/src/Microsoft.NET.WebAssembly.Webcil.csproj::TargetFramework=net8.0]
    CSC : warning CS8784: Generator 'LibraryImportGenerator' failed to initialize. It will not contribute to the output and compilation errors may occur as a result. Exception was of type 'FileNotFoundException' with message 'Could not load file or assembly 'Microsoft.Interop.SourceGeneration, Version=8.0.8.8002, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a'. The system cannot find the path specified. [/vmr/src/runtime/artifacts/source-build/self/src/src/tasks/WasmAppBuilder/WasmAppBuilder.csproj::TargetFramework=net8.0]
    CSC : warning CS8784: Generator 'LibraryImportGenerator' failed to initialize. It will not contribute to the output and compilation errors may occur as a result. Exception was of type 'FileNotFoundException' with message 'Could not load file or assembly 'Microsoft.Interop.SourceGeneration, Version=8.0.8.8002, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a'. The system cannot find the path specified. [/vmr/src/runtime/artifacts/source-build/self/src/src/tasks/WasmBuildTasks/WasmBuildTasks.csproj]
    CSC : warning CS8784: Generator 'LibraryImportGenerator' failed to initialize. It will not contribute to the output and compilation errors may occur as a result. Exception was of type 'FileNotFoundException' with message 'Could not load file or assembly 'Microsoft.Interop.SourceGeneration, Version=8.0.8.8002, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a'. The system cannot find the path specified. [/vmr/src/runtime/artifacts/source-build/self/src/src/tasks/WorkloadBuildTasks/WorkloadBuildTasks.csproj]
    CSC : warning CS8784: Generator 'LibraryImportGenerator' failed to initialize. It will not contribute to the output and compilation errors may occur as a result. Exception was of type 'FileNotFoundException' with message 'Could not load file or assembly 'Microsoft.Interop.SourceGeneration, Version=8.0.8.8002, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a'. The system cannot find the path specified. [/vmr/src/runtime/artifacts/source-build/self/src/src/libraries/System.Private.CoreLib/ref/System.Private.CoreLib.csproj]
    CSC : warning CS8784: Generator 'LibraryImportGenerator' failed to initialize. It will not contribute to the output and compilation errors may occur as a result. Exception was of type 'FileNotFoundException' with message 'Could not load file or assembly 'Microsoft.Interop.SourceGeneration, Version=8.0.8.8002, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a'. The system cannot find the path specified. [/vmr/src/runtime/artifacts/source-build/self/src/src/coreclr/System.Private.CoreLib/System.Private.CoreLib.csproj]
    /vmr/src/runtime/artifacts/source-build/self/src/src/coreclr/System.Private.CoreLib/src/System/Threading/Interlocked.CoreCLR.cs(231,37): error CS8795: Partial method 'Interlocked._MemoryBarrierProcessWide()' must have an implementation part because it has accessibility modifiers. [/vmr/src/runtime/artifacts/source-build/self/src/src/coreclr/System.Private.CoreLib/System.Private.CoreLib.csproj]
    /vmr/src/runtime/artifacts/source-build/self/src/src/coreclr/System.Private.CoreLib/src/System/Runtime/CompilerServices/RuntimeHelpers.CoreCLR.cs(53,37): error CS8795: Partial method 'RuntimeHelpers.RunClassConstructor(QCallTypeHandle)' must have an implementation part because it has accessibility modifiers. [/vmr/src/runtime/artifacts/source-build/self/src/src/coreclr/System.Private.CoreLib/System.Private.CoreLib.csproj]
    /vmr/src/runtime/artifacts/source-build/self/src/src/coreclr/System.Private.CoreLib/src/System/Runtime/CompilerServices/RuntimeHelpers.CoreCLR.cs(74,37): error CS8795: Partial method 'RuntimeHelpers.RunModuleConstructor(QCallModule)' must have an implementation part because it has accessibility modifiers. [/vmr/src/runtime/artifacts/source-build/self/src/src/coreclr/System.Private.CoreLib/System.Private.CoreLib.csproj]
    /vmr/src/runtime/artifacts/source-build/self/src/src/coreclr/System.Private.CoreLib/src/System/Runtime/CompilerServices/RuntimeHelpers.CoreCLR.cs(86,38): error CS8795: Partial method 'RuntimeHelpers.CompileMethod(RuntimeMethodHandleInternal)' must have an implementation part because it has accessibility modifiers. [/vmr/src/runtime/artifacts/source-build/self/src/src/coreclr/System.Private.CoreLib/System.Private.CoreLib.csproj]
    /vmr/src/runtime/artifacts/source-build/self/src/src/coreclr/System.Private.CoreLib/src/System/Runtime/CompilerServices/RuntimeHelpers.CoreCLR.cs(89,44): error CS8795: Partial method 'RuntimeHelpers.PrepareMethod(RuntimeMethodHandleInternal, nint*, int)' must have an implementation part because it has accessibility modifiers. [/vmr/src/runtime/artifacts/source-build/self/src/src/coreclr/System.Private.CoreLib/System.Private.CoreLib.csproj]
    /vmr/src/runtime/artifacts/source-build/self/src/src/coreclr/System.Private.CoreLib/src/System/Runtime/CompilerServices/RuntimeHelpers.CoreCLR.cs(186,37): error CS8795: Partial method 'RuntimeHelpers.GetUninitializedObject(QCallTypeHandle, ObjectHandleOnStack)' must have an implementation part because it has accessibility modifiers. [/vmr/src/runtime/artifacts/source-build/self/src/src/coreclr/System.Private.CoreLib/System.Private.CoreLib.csproj]
...

mthalman · 2023-01-31T21:49:46Z

I can see from a previously successful CI build that it also had these same warnings of LibraryImportGenerator. So that seems unrelated to the cause of this issue.

…e-sb-artifacts

This reverts commit 7d4a815.

MichaelSimons · 2023-01-31T23:53:32Z

I kicked off another local build and cannot reproduce this. I am running with prep.sh --bootstrap though. I wonder if this is an issue with the source-build artifacts when not utilizing the bootstrap flow.

mthalman · 2023-02-01T15:17:46Z

This sure is strange. I created a codespace from this PR and it doesn't repro there either. 🫤

mthalman · 2023-02-01T15:53:18Z

Ah, it repros when using the --clean-while-building option. How can that be?

MichaelSimons · 2023-02-01T16:08:19Z

Ah, it repros when using the --clean-while-building option. How can that be?

Oh that's a good discovery. Not sure why that is. IIRC clean while building only cleans up artifacts at the end of a repo build. Could this indicate an odd cross repo dependency outside of a nuget package?

ViktorHofer · 2023-02-02T08:27:57Z

@ViktorHofer - Are you aware of any runtime changes that might be causing the following errors?

@MichaelSimons I'm currently OOO - sick. Let me cc @jkoritzinsky who might be able to help.

jkoritzinsky · 2023-02-02T19:09:11Z

Could this be related to the fact that Microsoft.Interop.SourceGeneration is building with a prebuilt reference? I just saw the issue related to that on dotnet/runtime and am going to put out a PR to fix it.

…e-sb-artifacts

…s/installer into update-sb-artifacts

mthalman · 2023-02-03T15:48:20Z

I've narrowed things down a bit. This behavior does not occur if the arcade and command-line-api repos are not cleaned up after building them.

MichaelSimons · 2023-02-03T20:59:35Z

One thing I noticed is that if you rebuild after this fails, the build passes. This is an indicator that it isn't clean-while-building related because that only cleans up artifacts after building each repo in the full build context. This could be an indicator of a concurrency issue.

MichaelSimons · 2023-02-03T23:18:59Z

I am at a loss on this one. I have a working and failing binlog from the same commit. The parameters to the csc command of System.Private.CodeLib.csproj appear to be identical. The question I have is the following warning a red herring? As Matt pointed out earlier, he has found other working builds that pass with this same warnings.

CSC warning CS8784: Generator 'LibraryImportGenerator' failed to initialize. It will not contribute to the output and compilation errors may occur as a result. Exception was of type 'FileNotFoundException' with message 'Could not load file or assembly 'Microsoft.Interop.SourceGeneration, Version=8.0.8.8002, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a'. The system cannot find the path specified. [/repos/dotnet/src/runtime/artifacts/source-build/self/src/src/coreclr/System.Private.CoreLib/System.Private.CoreLib.csproj]

In regards to

Could this be related to the fact that Microsoft.Interop.SourceGeneration is building with a prebuilt reference? I just saw the issue related to that on dotnet/runtime and am going to put out a PR to fix it.

I don't think this is related. That PR is in regards to enabling the local prebuilt detection in the runtime repo.

mthalman · 2023-02-06T15:46:11Z

I also found that if you run build.sh once so that it targets all of runtime's dependencies (and only those dependencies) and then run build.sh again targeting only the runtime repo, the build will succeed. But if you include the runtime repo in that first build, it won't work.

…e-sb-artifacts

mthalman · 2023-02-07T14:38:12Z

I've isolated the repro to just the change in the SDK version. The other changes in this PR are not impacting this issue.

MichaelSimons · 2023-02-07T16:24:01Z

We need to unblock this PR for preview one. I have disabled the clean-while-building functionality and logged a tracking issue to investigate how this is causing the build to fail.

Co-authored-by: Matt Thalman <[email protected]>

jaredpar · 2023-08-31T17:26:54Z

The symptoms of this issue are very similar to dotnet/runtime#85082. Believe it's likely the same underlying problem.

MichaelSimons and others added 2 commits January 30, 2023 21:25

Update source-build artifacts to be coherant

9545778

Disable CheckEolTargetFramework for all projects (dotnet#15222)

3d3fd4b

MichaelSimons marked this pull request as ready for review January 31, 2023 03:21

MichaelSimons requested a review from a team as a code owner January 31, 2023 03:21

Merge branch 'main' into update-sb-artifacts

70acba8

MichaelSimons enabled auto-merge (squash) January 31, 2023 03:21

Suppress runtime build warning

7d4a815

MichaelSimons mentioned this pull request Jan 31, 2023

[release/8.0.1xx-preview1] Merge runtime workloads #15376

Merged

mthalman self-assigned this Jan 31, 2023

lewing closed this Jan 31, 2023

auto-merge was automatically disabled January 31, 2023 21:45
Pull request was closed

lewing reopened this Jan 31, 2023

MichaelSimons added 2 commits January 31, 2023 23:36

Merge branch 'main' of https://github.com/dotnet/installer into updat…

d278676

…e-sb-artifacts

Revert "Suppress runtime build warning"

6c07e45

This reverts commit 7d4a815.

Merge branch 'main' into update-sb-artifacts

a5fbfad

MichaelSimons added the Area-SourceBuild label Feb 2, 2023

MichaelSimons added 2 commits February 2, 2023 23:52

Merge branch 'main' of https://github.com/dotnet/installer into updat…

9610667

…e-sb-artifacts

Merge branch 'update-sb-artifacts' of https://github.com/MichaelSimon…

ce2b091

…s/installer into update-sb-artifacts

MichaelSimons added 2 commits February 7, 2023 04:10

Disable cleanup

3df958c

Merge branch 'main' of https://github.com/dotnet/installer into updat…

dcc3666

…e-sb-artifacts

mthalman approved these changes Feb 7, 2023

View reviewed changes

MichaelSimons mentioned this pull request Feb 7, 2023

Re-enable clean-while-building dotnet/source-build#3233

Closed

Refactor how clean-while-building is disabled

ecd6dec

MichaelSimons enabled auto-merge (squash) February 7, 2023 16:42

MichaelSimons merged commit 593bfe8 into dotnet:main Feb 7, 2023

MichaelSimons deleted the update-sb-artifacts branch February 7, 2023 17:18

MichaelSimons added a commit to MichaelSimons/installer that referenced this pull request Feb 7, 2023

Update source-build artifacts to be coherent (dotnet#15372)

67cbd57

Co-authored-by: Matt Thalman <[email protected]>

MichaelSimons mentioned this pull request Feb 7, 2023

[release/8.0.1xx-preview1] Update source-build artifacts to be coherent #15452

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update source-build artifacts to be coherent #15372

Update source-build artifacts to be coherent #15372

MichaelSimons commented Jan 30, 2023

MichaelSimons commented Jan 31, 2023

mthalman commented Jan 31, 2023

MichaelSimons commented Jan 31, 2023

mthalman commented Feb 1, 2023

mthalman commented Feb 1, 2023

MichaelSimons commented Feb 1, 2023

ViktorHofer commented Feb 2, 2023

jkoritzinsky commented Feb 2, 2023

mthalman commented Feb 3, 2023

MichaelSimons commented Feb 3, 2023

MichaelSimons commented Feb 3, 2023

mthalman commented Feb 6, 2023

mthalman commented Feb 7, 2023

MichaelSimons commented Feb 7, 2023

jaredpar commented Aug 31, 2023 •

edited

Loading

Update source-build artifacts to be coherent #15372

Update source-build artifacts to be coherent #15372

Conversation

MichaelSimons commented Jan 30, 2023

MichaelSimons commented Jan 31, 2023

mthalman commented Jan 31, 2023

MichaelSimons commented Jan 31, 2023

mthalman commented Feb 1, 2023

mthalman commented Feb 1, 2023

MichaelSimons commented Feb 1, 2023

ViktorHofer commented Feb 2, 2023

jkoritzinsky commented Feb 2, 2023

mthalman commented Feb 3, 2023

MichaelSimons commented Feb 3, 2023

MichaelSimons commented Feb 3, 2023

mthalman commented Feb 6, 2023

mthalman commented Feb 7, 2023

MichaelSimons commented Feb 7, 2023

jaredpar commented Aug 31, 2023 • edited Loading

jaredpar commented Aug 31, 2023 •

edited

Loading