Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update delete files with questionable licenses logic #14265

Merged

Conversation

MichaelSimons
Copy link
Member

The logic to delete files with questionable licenses logic regressed with the changes to support the VMR where the commit digest was removed from the repo names in the tarball.

Related to #14264

@MichaelSimons MichaelSimons requested a review from a team as a code owner August 5, 2022 14:51
Copy link

@lbussell lbussell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@omajid just so you're aware, these files might have made it into some 6.0 release tarballs.

@MichaelSimons MichaelSimons merged commit e759aaf into dotnet:release/6.0.1xx Aug 5, 2022
@MichaelSimons MichaelSimons deleted the cleanup-licenses-6.0 branch August 5, 2022 19:26
@omajid
Copy link
Member

omajid commented Aug 5, 2022

Thanks for the heads up.

It looks like we (Fedora/RHEL) redundantly delete those files again: https://src.fedoraproject.org/rpms/dotnet6.0/blob/rawhide/f/build-dotnet-tarball#_198 so we should be okay.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants