Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prep reorganize string module for String.xxx changes #9481

Merged
merged 1 commit into from
Jun 18, 2020

Conversation

abelbraaksma
Copy link
Contributor

@abelbraaksma abelbraaksma commented Jun 17, 2020

Several upcoming PR's related to String functions, need String.length, which was defined at the bottom. Putting it on top so that the function length gets in scope of the others.

No functional changes here.

Related to #9390.

Copy link
Contributor

@cartermp cartermp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@cartermp
Copy link
Contributor

Weirdly the "fsharp-ci" (which is neither a CI leg nor contains any tests) is shown as cancelled. But everything else passes, so I will merge this.

@cartermp cartermp merged commit 194b6c7 into dotnet:master Jun 18, 2020
@abelbraaksma abelbraaksma deleted the Prep-reorganize-string-mod branch June 18, 2020 09:52
nosami pushed a commit to xamarin/visualfsharp that referenced this pull request Feb 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants