-
Notifications
You must be signed in to change notification settings - Fork 805
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] ConstraintSolver internal error fix #5583
Conversation
cc @gusty |
@gusty this one is slightly different, instead of returning the This one is going to be very tricky. It seems even a slight tweak will change behavior in a way that isn't expected. |
@dsyme could comment further, but I suspect that if we cannot derive a fix for the internal error without breaking some kind of SRTP behavior, we'll either: (a) Never fix it, thus keeping this wart here forever |
I know it's gonna be tricky, the way I see it is that if it's not possible to fix it in such a way |
IIRC the break that eventually caused a re-reversion has had that project undergo changes so that they weren't dependent on the broken behavior, so I do lean towards (b), since it is a major language change where we'll be doing other "invasive" things (Nullable References). |
|
This is still WIP and will not be in dev15.9. It could have been if the fix was quick and didn't break other stuff; but unfortunately it did. The correct fix will take considerable more time to figure out. |
Why was this closed? |
Looks like it was auto-closed when I cleaned up the |
Since this was not solved, can we revert again to the correct behavior and use the language switch for F# 4.7? |
Resolving this issue: #5580
Should not regress: #4343 (comment)