Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Obsolete attribute checking to account for diagnosticId and urlFormat properties #18224

Merged
merged 16 commits into from
Jan 20, 2025
Merged

Update Obsolete attribute checking to account for diagnosticId and urlFormat properties #18224

merged 16 commits into from
Jan 20, 2025

Conversation

edgarfgp
Copy link
Contributor

@edgarfgp edgarfgp commented Jan 10, 2025 •
edited
Loading

Description

Fixes #8654

Checklist

  • Test cases added
  • Release notes entry updated

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 10, 2025 •
edited
Loading

❗ Release notes required

✅ Found changes and release notes in following paths:

Change path Release notes path Description
src/Compiler docs/release-notes/.FSharp.Compiler.Service/9.0.300.md

@edgarfgp edgarfgp marked this pull request as ready for review January 10, 2025 20:58
@edgarfgp edgarfgp requested a review from a team as a code owner January 10, 2025 20:58
@edgarfgp edgarfgp force-pushed the fix-8654 branch 2 times, most recently from 226a7b7 to f831448 Compare January 18, 2025 16:00
@edgarfgp edgarfgp requested a review from T-Gro January 20, 2025 09:20
@T-Gro T-Gro enabled auto-merge (squash) January 20, 2025 15:05
@T-Gro T-Gro merged commit 4b676b4 into dotnet:main Jan 20, 2025
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@psfinaki psfinaki psfinaki left review comments

@T-Gro T-Gro T-Gro approved these changes

@KevinRansom KevinRansom KevinRansom approved these changes

Assignees
No one assigned
Labels
None yet
Projects
F# Compiler and Tooling
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Honor new properties on ObsoleteAttribute for .NET 5
4 participants
@edgarfgp @KevinRansom @psfinaki @T-Gro