-
Notifications
You must be signed in to change notification settings - Fork 795
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Shim/file system: fix leaks of the shim #18144
Conversation
❗ Release notes required
|
We can also hide the mutable shim behind a property, so capturing the getter wouldn't be a problem. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just for my understanding, did you search for all usages of " >> FileSystem" or something similar?
I like this encapsulation proposal more. |
Yes, I've looked through all the usages. |
Fixes the file system shim is leaked after a solution is closed: