fix OriginalLine processing in lexing #17949
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Can somebody add the "no release notes" label? Also a note to reviewers: the whole fix is just 5 characters in 1 file. |
T-Gro
added
the
NO_RELEASE_NOTES
T-Gro
approved these changes
Nov 4, 2024
psfinaki
approved these changes
Nov 4, 2024
This was referenced Dec 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes two bugs in processing
Position.OriginalLineduring lexing.This field is foreseen in FsLex, but was hardly used in the compiler, and only for equality checks.
Therefore this fix does not change current compiler behavior, but will enable features like "scoped nowarn" that will depend on correct values of
OriginalLine.Note that this is not a FsLex issue, but only present in the compiler.
A test has been added to check the line numbers.
Checklist