Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch to new VMR control set #17703

Merged
merged 12 commits into from
Sep 16, 2024
Merged

Switch to new VMR control set #17703

merged 12 commits into from
Sep 16, 2024

Conversation

mmitche
Copy link
Member

@mmitche mmitche commented Sep 11, 2024

Description

Now that fsharp is on 9.0, we can switch to the new control set. Generally:

  • DotNetBuildFromSource -> DotNetBuildSourceOnly - Building a source-only build.
  • DotnetBuildFromSourceFlavor == Product -> DotNetBuildOrchestrator == true - Building in the VMR, could be source-only or MS's build.
  • ArcadeBuildFromSource -> DotNetBuildRepo == true -> Indicates an outer repo build.

Fixes # (issue, if applicable)

Checklist

  • Test cases added

  • Performance benchmarks added in case of performance changes

  • Release notes entry updated:

    Please make sure to add an entry with short succinct description of the change as well as link to this pull request to the respective release notes file, if applicable.

    Release notes files:

    • If anything under src/Compiler has been changed, please make sure to make an entry in docs/release-notes/.FSharp.Compiler.Service/<version>.md, where <version> is usually "highest" one, e.g. 42.8.200
    • If language feature was added (i.e. LanguageFeatures.fsi was changed), please add it to docs/release-notes/.Language/preview.md
    • If a change to FSharp.Core was made, please make sure to edit docs/release-notes/.FSharp.Core/<version>.md where version is "highest" one, e.g. 8.0.200.

    Information about the release notes entries format can be found in the documentation.
    Example:

    If you believe that release notes are not necessary for this PR, please add NO_RELEASE_NOTES label to the pull request.

@mmitche
Now that fsharp is on 9.0, we can switch to the new control set. Gene…
5ac523e 
…rally:

- DotNetBuildFromSource -> DotNetBuildSourceOnly - Building a source-only build.
- DotnetBuildFromSourceFlavor == Product -> DotNetBuildOrchestrator == true - Building in the VMR, could be source-only or MS's build.
- ArcadeBuildFromSource -> DotNetBuildRepo == true -> Indicates an outer repo build.
@mmitche mmitche requested review from a team as code owners September 11, 2024 21:51
@github-actions GitHub Actions
Copy link
Contributor

✅ No release notes required

@psfinaki
Copy link
Member

@mmitche so it's MIBC again 👀

I introduced PGO to this repo a few weeks ago here, it doesn't play well with source build (see the discussion in that PR), and we shouldn't ignore the packages either, so we disabled PGO-related logic for MIBC.

Given that in this PR the optimization packages pop up again, something doesn't play well together, IgnoreMIBC is not being set. I might look at this locally later today.

@psfinaki
Copy link
Member

That's really weird. It looks like as if MSBuild wasn't setting this property up internally after receiving the new flags.

@mmitche
Copy link
Member Author

mmitche commented Sep 12, 2024

I'll take a look too.

@psfinaki
Copy link
Member

/azp run

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@psfinaki
Copy link
Member

Alright, that seems to work - thanks @mmitche!

@psfinaki
Copy link
Member

@dotnet/source-build-internal

MichaelSimons
MichaelSimons approved these changes Sep 16, 2024
View reviewed changes
eng/SourceBuild.props Outdated Show resolved Hide resolved
@psfinaki psfinaki merged commit 7bfb032 into dotnet:main Sep 16, 2024
32 checks passed
mmitche added a commit to mmitche/fsharp that referenced this pull request Sep 25, 2024
@mmitche @psfinaki
Switch to new VMR control set (dotnet#17703)
bb90cc6 
* Now that fsharp is on 9.0, we can switch to the new control set. Generally:
- DotNetBuildFromSource -> DotNetBuildSourceOnly - Building a source-only build.
- DotnetBuildFromSourceFlavor == Product -> DotNetBuildOrchestrator == true - Building in the VMR, could be source-only or MS's build.
- ArcadeBuildFromSource -> DotNetBuildRepo == true -> Indicates an outer repo build.
- ExcludeFromSourceBuild -> ExcludeFromSourceOnlyBuild

* Split out source build args

* Split out source build args

* Remove unnecessary source build env var set

* Add properties to the bootstrap compiler build

* BuildRepo -> BuildInnerRepo

* Only build proto repo in inner build

* Additional VMR properties for completeness

* Rename sourcebuild.props -> dotnetbuild.props

---------

Co-authored-by: Petr <[email protected]>
vzarytovskii pushed a commit that referenced this pull request Sep 26, 2024
@mmitche @psfinaki
Switch to new VMR control set (#17703) (port from main) (#17788)
44f5feb 
* Now that fsharp is on 9.0, we can switch to the new control set. Generally:
- DotNetBuildFromSource -> DotNetBuildSourceOnly - Building a source-only build.
- DotnetBuildFromSourceFlavor == Product -> DotNetBuildOrchestrator == true - Building in the VMR, could be source-only or MS's build.
- ArcadeBuildFromSource -> DotNetBuildRepo == true -> Indicates an outer repo build.
- ExcludeFromSourceBuild -> ExcludeFromSourceOnlyBuild

* Split out source build args

* Split out source build args

* Remove unnecessary source build env var set

* Add properties to the bootstrap compiler build

* BuildRepo -> BuildInnerRepo

* Only build proto repo in inner build

* Additional VMR properties for completeness

* Rename sourcebuild.props -> dotnetbuild.props

---------

Co-authored-by: Petr <[email protected]>
vzarytovskii added a commit that referenced this pull request Oct 7, 2024
@dotnet-bot @vzarytovskii
@psfinaki @T-Gro @KevinRansom @github-actions @mmitche
Merge release/dev17.12 to main (#17842)
c4850d6 
* Update azure-pipelines.yml

* Refactor CE checking (#17464) (#17493)

Co-authored-by: Vlad Zarytovskii <[email protected]>
Co-authored-by: vzarytovskii <[email protected]>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* Update azure-pipelines.yml

* Localized file check-in by OneLocBuild Task: Build definition ID 499: Build ID 2524346 (#17610)

* Fixes #17447 -MethodAccessException on equality comparison of a record with private fields (#17467)

* Fix17447

* tests + readme

* fixes #17541 - Equals visibility for DU's (#17548)

* update version number

* Switch to new VMR control set (#17703) (port from main) (#17788)

* Now that fsharp is on 9.0, we can switch to the new control set. Generally:
- DotNetBuildFromSource -> DotNetBuildSourceOnly - Building a source-only build.
- DotnetBuildFromSourceFlavor == Product -> DotNetBuildOrchestrator == true - Building in the VMR, could be source-only or MS's build.
- ArcadeBuildFromSource -> DotNetBuildRepo == true -> Indicates an outer repo build.
- ExcludeFromSourceBuild -> ExcludeFromSourceOnlyBuild

* Split out source build args

* Split out source build args

* Remove unnecessary source build env var set

* Add properties to the bootstrap compiler build

* BuildRepo -> BuildInnerRepo

* Only build proto repo in inner build

* Additional VMR properties for completeness

* Rename sourcebuild.props -> dotnetbuild.props

---------

Co-authored-by: Petr <[email protected]>

* respect generic arity in method uniqueness

* [17.12] Turn off realsig when building product and proto (#17808)

* Bugfix : make sure nullness does not break XmlDoc info import for methods and types (#17741)

* Remove nullness signal in string-based type encoding of a symbol (since it is used for xmldoc lookup)

* release notes

* Discard unused values

* Rendering AllowsRefStruct for type parameters (#17706)

* Update azure-pipelines.yml

---------

Co-authored-by: Vlad Zarytovskii <[email protected]>
Co-authored-by: Petr <[email protected]>
Co-authored-by: Tomas Grosup <[email protected]>
Co-authored-by: Kevin Ransom (msft) <[email protected]>
Co-authored-by: vzarytovskii <[email protected]>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Kevin Ransom <[email protected]>
Co-authored-by: Matt Mitchell <[email protected]>
This was referenced Oct 31, 2024
Closed
Closed
@dotnet-bot dotnet-bot mentioned this pull request Nov 19, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@psfinaki psfinaki psfinaki approved these changes

@MichaelSimons MichaelSimons MichaelSimons approved these changes

@T-Gro T-Gro T-Gro approved these changes

Assignees
No one assigned
Labels
None yet
Projects
F# Compiler and Tooling
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mmitche @psfinaki @MichaelSimons @T-Gro