Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nullness - prevent duplicate warnings coming from speculative method resolution #17477

Merged
merged 2 commits into from
Aug 5, 2024

Conversation

T-Gro
Copy link
Member

@T-Gro T-Gro commented Aug 1, 2024

Fixes #17410.

Reason was contraint solver being invoked twice, once for identifying the best candidate for method resolution (speculative mode), and then once more for real.

Copy link
Contributor

github-actions bot commented Aug 1, 2024

⚠️ Release notes required, but author opted out

Warning

Author opted out of release notes, check is disabled for this pull request.
cc @dotnet/fsharp-team-msft

@T-Gro
Copy link
Member Author

T-Gro commented Aug 1, 2024

/azp run

Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@T-Gro T-Gro added the NO_RELEASE_NOTES Label for pull requests which signals, that user opted-out of providing release notes label Aug 2, 2024
@T-Gro T-Gro marked this pull request as ready for review August 2, 2024 07:07
@T-Gro T-Gro requested a review from a team as a code owner August 2, 2024 07:07
Copy link
Member

@psfinaki psfinaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

I guess technically this could be in release notes but up to you.

@T-Gro T-Gro self-assigned this Aug 2, 2024
@psfinaki psfinaki merged commit 599bb69 into main Aug 5, 2024
30 of 31 checks passed
@T-Gro T-Gro deleted the nullness-prevent-duplicates branch September 9, 2024 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
NO_RELEASE_NOTES Label for pull requests which signals, that user opted-out of providing release notes
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Nullness bug - duplicate warning for the same range
4 participants