-
Notifications
You must be signed in to change notification settings - Fork 790
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Symbol Signature text API #15275
Symbol Signature text API #15275
Conversation
Do you have a real use case in mind already? |
Adding a member or binding to an existing signature file. Or updating an outdated one. |
Thats sounds nice. We should pilot it in VS as method lens actions (not entirely sure what is the proper name for those). Cc @psfinaki |
4a97c41
to
9857373
Compare
Might be useful for signature hints. Will look at this in the upcoming days - thanks! |
This API is working out very well for me in Telplin. (Proof of concept in nojaf/telplin#77). What Telplin does, is traverse the untyped tree to generate a signature counterpart. The As mentioned in the OP, I have incremental editor scenarios in mind as well for this. To summarize, can we have this, please? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks!
Head branch was pushed to by a user without write access
Thanks all! |
Related to #13215 and #14170
I want to add a new API to
FSharpMemberOrFunctionOrValue
to return the "signature text" via theNicePrint
API. This would be useful for editors to provide a light bulb kind of action to add a member or binding to an existing signature file.I'm not quite sure yet about the name or exact API but I'm very happy with the initial results of this. It is quite accurate and has a lot of details right.
For example:
gives for
f
Or
gives for
Empty
Let me know what you think.