-
Notifications
You must be signed in to change notification settings - Fork 790
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release/dev17.7] Update dependencies from dotnet/source-build-reference-packages #15248
[release/dev17.7] Update dependencies from dotnet/source-build-reference-packages #15248
Conversation
…ence-packages build 20230522.1 Microsoft.SourceBuild.Intermediate.source-build-reference-packages From Version 8.0.0-alpha.1.23262.1 -> To Version 8.0.0-alpha.1.23272.1 Dependency coherency updates Microsoft.SourceLink.GitHub From Version 8.0.0-beta.23218.3 -> To Version 8.0.0-beta.23227.4 (parent: Microsoft.DotNet.Arcade.Sdk
@NikolaMilosavljevic we ahve some weird issues here with source build detection, is it something we can fix? Update: also, same issue here #15204 |
…a-448c-8840-49f06aaf6cb1
…ence-packages build 20230524.2 Microsoft.SourceBuild.Intermediate.source-build-reference-packages From Version 8.0.0-alpha.1.23262.1 -> To Version 8.0.0-alpha.1.23274.2 Dependency coherency updates Microsoft.SourceLink.GitHub From Version 8.0.0-beta.23218.3 -> To Version 8.0.0-beta.23227.4 (parent: Microsoft.DotNet.Arcade.Sdk
…ence-packages build 20230602.3 Microsoft.SourceBuild.Intermediate.source-build-reference-packages From Version 8.0.0-alpha.1.23262.1 -> To Version 8.0.0-alpha.1.23302.3 Dependency coherency updates Microsoft.SourceLink.GitHub From Version 8.0.0-beta.23218.3 -> To Version 8.0.0-beta.23227.4 (parent: Microsoft.DotNet.Arcade.Sdk
@NikolaMilosavljevic it's still failing in CI, anything we can do here? |
…a-448c-8840-49f06aaf6cb1
Taking a look now... |
This started failing after #15204 Several |
It's certainly odd - SBRP repo updates are trying to bring an update to I'm preparing a fix for this PR, but this needs to be root-caused as it will likely happen again. @mmitche we need your help to understand why coherency updates are triggered for sbrp flow into |
I've pushed the fix for |
I think the issue is that in #15204, the base branch was changed to the net8 branch, which may have confused Maestro. That said, there are coherency issues here that cause a failure in strict coherency, which then causes Maestro to fall back to legacy, where some odd behavior may occur. I've pushed a fix. |
…a-448c-8840-49f06aaf6cb1
…a-448c-8840-49f06aaf6cb1
This pull request updates the following dependencies
Coherency Updates
The following updates ensure that dependencies with a CoherentParentDependency
attribute were produced in a build used as input to the parent dependency's build.
See Dependency Description Format
From https://github.com/dotnet/source-build-reference-packages