Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/dev17.7] Update dependencies from dotnet/source-build-reference-packages #15248

Conversation

dotnet-maestro[bot]
Copy link
Contributor

@dotnet-maestro dotnet-maestro bot commented May 22, 2023

This pull request updates the following dependencies

Coherency Updates

The following updates ensure that dependencies with a CoherentParentDependency
attribute were produced in a build used as input to the parent dependency's build.
See Dependency Description Format

  • Coherency Updates:
    • Microsoft.SourceLink.GitHub: from 8.0.0-beta.23218.3 to 8.0.0-beta.23227.4 (parent: Microsoft.DotNet.Arcade.Sdk)

From https://github.com/dotnet/source-build-reference-packages

  • Subscription: 8acd2309-4ce8-446b-3a60-08db5630d164
  • Build: 20230602.3
  • Date Produced: June 2, 2023 8:19:50 PM UTC
  • Commit: 4a3b4b6b37bdafe501477bf2e564380e1962ce61
  • Branch: refs/heads/main

…ence-packages build 20230522.1

Microsoft.SourceBuild.Intermediate.source-build-reference-packages
 From Version 8.0.0-alpha.1.23262.1 -> To Version 8.0.0-alpha.1.23272.1

Dependency coherency updates

Microsoft.SourceLink.GitHub
 From Version 8.0.0-beta.23218.3 -> To Version 8.0.0-beta.23227.4 (parent: Microsoft.DotNet.Arcade.Sdk
@dotnet-maestro dotnet-maestro bot requested a review from a team as a code owner May 22, 2023 13:19
@vzarytovskii
Copy link
Member

vzarytovskii commented May 24, 2023

@NikolaMilosavljevic we ahve some weird issues here with source build detection, is it something we can fix?
Also, we have created a new branch release/net8, which now inserts into SDK main, should these auto-PRs go there as well?

Update: also, same issue here #15204

vzarytovskii and others added 3 commits May 24, 2023 13:02
…ence-packages build 20230524.2

Microsoft.SourceBuild.Intermediate.source-build-reference-packages
 From Version 8.0.0-alpha.1.23262.1 -> To Version 8.0.0-alpha.1.23274.2

Dependency coherency updates

Microsoft.SourceLink.GitHub
 From Version 8.0.0-beta.23218.3 -> To Version 8.0.0-beta.23227.4 (parent: Microsoft.DotNet.Arcade.Sdk
…ence-packages build 20230602.3

Microsoft.SourceBuild.Intermediate.source-build-reference-packages
 From Version 8.0.0-alpha.1.23262.1 -> To Version 8.0.0-alpha.1.23302.3

Dependency coherency updates

Microsoft.SourceLink.GitHub
 From Version 8.0.0-beta.23218.3 -> To Version 8.0.0-beta.23227.4 (parent: Microsoft.DotNet.Arcade.Sdk
@vzarytovskii
Copy link
Member

@NikolaMilosavljevic it's still failing in CI, anything we can do here?

@NikolaMilosavljevic
Copy link
Member

@NikolaMilosavljevic it's still failing in CI, anything we can do here?

Taking a look now...

@NikolaMilosavljevic
Copy link
Member

@NikolaMilosavljevic it's still failing in CI, anything we can do here?

Taking a look now...

This started failing after #15204

Several sourcelink packages are showing as prebuilts. #15204 should have updated the sourcelink dependencies due to CoherentParentDependency="Microsoft.DotNet.Arcade.Sdk". @mmitche do you know why coherency was not honored in this repo? Perhaps something is not set-up right.

@NikolaMilosavljevic
Copy link
Member

@NikolaMilosavljevic it's still failing in CI, anything we can do here?

Taking a look now...

This started failing after #15204

Several sourcelink packages are showing as prebuilts. #15204 should have updated the sourcelink dependencies due to CoherentParentDependency="Microsoft.DotNet.Arcade.Sdk". @mmitche do you know why coherency was not honored in this repo? Perhaps something is not set-up right.

It's certainly odd - SBRP repo updates are trying to bring an update to sourcelink dependency: c5be89c

I'm preparing a fix for this PR, but this needs to be root-caused as it will likely happen again. @mmitche we need your help to understand why coherency updates are triggered for sbrp flow into fsharp.

@NikolaMilosavljevic
Copy link
Member

I've pushed the fix for sourcelink dependency.

@mmitche
Copy link
Member

mmitche commented Jun 5, 2023

I think the issue is that in #15204, the base branch was changed to the net8 branch, which may have confused Maestro. That said, there are coherency issues here that cause a failure in strict coherency, which then causes Maestro to fall back to legacy, where some odd behavior may occur.

I've pushed a fix.

@vzarytovskii vzarytovskii merged commit 12c682e into release/dev17.7 Jun 7, 2023
@dotnet-maestro dotnet-maestro bot deleted the darc-release/dev17.7-9b834e44-06ca-448c-8840-49f06aaf6cb1 branch June 7, 2023 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants