Deploy only compressed metadata for dotnet sdk implementation #15230
Conversation
|
What concerns me is that people update fsharp.core quite often without updating sdk, which may result in either cryptic errors or undefined behavior. |
@vzarytovskii the nuget package that we embed in the sdk FSharp\library-packs folder and ship to nuget still has uncompressed metadata. This change only impacts the files that form the compiler implementation. |
OH, got it now |
|
|
Although, I should check that the options are the correct ones matching release. Checked, it builds the bits with the correct switches. |
src/FSharp.DependencyManager.Nuget/FSharp.DependencyManager.Nuget.fsproj
Show resolved
Hide resolved
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
* LexFilter: cleanup whitespaces (#15250) * Parser: rewrite tuple expr recovery to allow better items recovery (#15227) * Checker: recover on unknown record fields (#15214) * Make anycpu work correctly on Arm64 (#15234) * Makeanuycpu work correctly on arm64 * Update Microsoft.FSharp.Targets * Fix15254 (#15257) * Deploy only compressed metadata for dotnet sdk implementation (#15230) * compress fsharp for sdk * Update FSharp.DependencyManager.Nuget.fsproj * Parser: more binary expressions recovery (#15255) * Use background CancellableTask in VS instead of async & asyncMaybe (#15187) * wip * iteration * iteration: quickinfo, help context * fantomas * todo * moved tasks to editor project, fixed comment colouring bug * fantomas * Fantomas + PR feedback * Update vsintegration/src/FSharp.Editor/Hints/HintService.fs Co-authored-by: Andrii Chebukin <[email protected]> * Revert "Update vsintegration/src/FSharp.Editor/Hints/HintService.fs" This reverts commit bf51b31. --------- Co-authored-by: Andrii Chebukin <[email protected]> * Name resolution: actually add reported item when trying to replace (#14772) Co-authored-by: Tomas Grosup <[email protected]> * Move flatErrors tests from fsharpqa (#15251) * temp * tests * flaterrors * update tests * preserve ranges in result of UnsolvedTyparsOfModuleDef to help with warnings (#15243) * preserve ranges in result of UnsolvedTyparsOfModuleDef to help with warnings * use fallback range only for range0 * pattern match instead of Option.isSome * Add test * Revert "Add test" This reverts commit e05e808. * Make `FSharpReferencedProject` representation public (#15266) * Make FSharpReferencedProject representation public * Update surface area * Fantomas * Fantomas --------- Co-authored-by: Tomas Grosup <[email protected]> * Fix navigation for external enums, DUs and name resultion for members (#15270) * Update FSharp.Compiler.Service.SurfaceArea.netstandard20.debug.bsl * Add warning when compiler selects among multiple record type candidates, fslang-suggestion 1091 (#15256) * Protect assembly exploration for C# extension members (#15271) * Compute ValInline.Never for externs (#15274) * Compute ValInline.Never for externs --------- Co-authored-by: Eugene Auduchinok <[email protected]> Co-authored-by: Kevin Ransom (msft) <[email protected]> Co-authored-by: Vlad Zarytovskii <[email protected]> Co-authored-by: Andrii Chebukin <[email protected]> Co-authored-by: Tomas Grosup <[email protected]> Co-authored-by: dawe <[email protected]>
When we deploy fsharp.core and fsharp.compiler.service to nuget we deploy uncompressed metadata because we need the LTS dotnet sdk to be usable in building apps consuming them. The current LTS does not understand compressed F# metadata.
However, the implementation F# compiler in the latest dotnet SDK understands compressed F# metadata so we don't need to waste those compressable bytes.
With this PR ... the dotnet SDK should be almost 3 MBytes smaller on disk and in VM, which has to be a good thing.