Fix Async.Parallel stack overflow on cancellation of ~2000 uncompleted #13186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vzarytovskii
approved these changes
May 23, 2022
|
Transient failure: |
bartelink
reviewed
May 23, 2022
tests/FSharp.Core.UnitTests/FSharp.Core/Microsoft.FSharp.Control/AsyncModule.fs
Outdated
Show resolved
Hide resolved
bartelink
reviewed
May 23, 2022
| let gen (i : int) = async { | ||
| if i <> 0 then do! Async.Sleep i | ||
| else return failwith (string i) } | ||
| let count = 1800 |
There was a problem hiding this comment.
if this is to function as a regression test in perpetuity and/or across platforms/processors, perhaps doubling this empirically derived value might make sense?
|
One leg is failing with:
AFAIU dnceng are working on it, @brettfo is that correct? |
bartelink
reviewed
May 23, 2022
| @@ -764,3 +764,15 @@ type AsyncModule() = | |||
| lock gate <| fun () -> printfn "Unhandled exception: %s" exn.Message | |||
| lock gate <| fun () -> printfn "Semaphore count available: %i" semaphore.CurrentCount | |||
| Assert.AreEqual(acquiredCount, releaseCount) | |||
|
|
|||
| [<Fact>] | |||
| member _.``Async.Parallel blows stack when cancelling many`` () = | |||
There was a problem hiding this comment.
Suggested change
| member _.``Async.Parallel blows stack when cancelling many`` () = | |
| // versions 4.7 - 6.0.4 impl didn't tail recurse as intended and hence can blow the stack given ~1600 excess computations at point of cancellation | |
| member _.``Async.Parallel handles early cancelation of large computation streams safely`` () = |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #13165