UnmanagedCallersOnlyAttribute is unsupported #12350
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsyme
reviewed
Nov 8, 2021
src/fsharp/TcGlobals.fs
Outdated
| @@ -1227,6 +1227,7 @@ type public TcGlobals(compilingFslib: bool, ilg:ILGlobals, fslibCcu: CcuThunk, d | |||
| member val attribs_Unsupported = [ | |||
| tryFindSysAttrib "System.Runtime.CompilerServices.ModuleInitializerAttribute" | |||
| tryFindSysAttrib "System.Runtime.CompilerServices.CallerArgumentExpressionAttribute" | |||
| tryFindSysAttrib "System.Runtime.InteropServices.UnmanagedCallersOnlyAttribute" | |||
There was a problem hiding this comment.
This is a bit subtle with regard to performance. Could you factor out attribs_Unsupported to a let v_unsupportedAttributes = ... please to make it clearer?
There was a problem hiding this comment.
Should all member vals be refactored to let because we have to avoid "subtle performance"? member val should be known as init-once-only.
There was a problem hiding this comment.
Only if involving a complex mult-line expression, especially something that involved pipelining or is unusual. I just had to think twice about what we had here
KevinRansom
approved these changes
Nov 22, 2021
vzarytovskii
approved these changes
Nov 23, 2021
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.