[WIP] Parallel ILX Codegen #11531
Closed
[WIP] Parallel ILX Codegen #11531
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o commit delayed diagnostics
TIHan
commented
May 6, 2021
src/fsharp/ParseAndCheckInputs.fs
Outdated
| @@ -712,6 +712,9 @@ type TcState = | |||
| { x with tcsTcSigEnv = tcEnvAtEndOfLastInput | |||
| tcsTcImplEnv = tcEnvAtEndOfLastInput } | |||
|
|
|||
| member x.RemoveImpl qualifiedNameOfFile = | |||
There was a problem hiding this comment.
The changes made in ParseAndCheckInputs is from #11152 and needs to be removed in this PR.
TIHan
commented
May 6, 2021
src/fsharp/absil/bytes.fs
Outdated
| @@ -439,10 +440,16 @@ type internal ByteBuffer = | |||
| let oldBufSize = buf.bbArray.Length | |||
| if newSize > oldBufSize then | |||
| let old = buf.bbArray | |||
| buf.bbArray <- Bytes.zeroCreate (max newSize (oldBufSize * 2)) | |||
| buf.bbArray <- ArrayPool.Shared.Rent(max newSize (oldBufSize * 2)) | |||
There was a problem hiding this comment.
This change should not be in this PR.
|
@TIHan let me know if you want me to take care of FileSystem changes related merge conflicts. |
|
Closing as I revived it in a different branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows for the ability for the compiler to parallelize ILX codegen by each file's methods/functions. Last I checked, the perf gain was something similar to what we got from parallel parsing.
The one thing we really need to make sure is that the compiler is still deterministic. As an example, we will probably have to make changes to how closure names are generated.
PR Dependencies
Acceptance Criteria