Add field names to types in TypedTree #10814
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vzarytovskii
approved these changes
Dec 29, 2020
|
@vzarytovskii Great to hear! I'll probably do more follow-up PRs then :) |
cartermp
approved these changes
Dec 29, 2020
| @@ -2359,18 +2363,18 @@ type TraitConstraintSln = | |||
| /// ty -- the type and its instantiation | |||
| /// vref -- the method that solves the trait constraint | |||
| /// minst -- the generic method instantiation | |||
| | FSMethSln of TType * ValRef * TypeInst | |||
| | FSMethSln of ty: TType * vref: ValRef * minsts: TypeInst | |||
| @@ -4825,7 +4829,7 @@ type ValUseFlag = | |||
| /// a .NET 2.0 constrained call. A constrained call is only used for calls where | |||
| // the object argument is a value type or generic type, and the call is to a method | |||
| // on System.Object, System.ValueType, System.Enum or an interface methods. | |||
| | PossibleConstrainedCall of TType | |||
| | PossibleConstrainedCall of typ: TType | |||
|
@ScottHutchinson Shall I correct them in a follow-up PR? |
|
I guess so, since this one has been merged. I don't know how else to do it. Sorry I didn't review this before it was merged. I have no authority here, so do as you think best. |
|
Will do. I was planning to do a follow-up anyway :) |
|
@ScottHutchinson I've fixed the issue you mentioned in https://github.com/dotnet/fsharp/pull/10820/files |
nosami
pushed a commit
to xamarin/visualfsharp
that referenced
this pull request
Feb 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As suggested in the Learn me some F# compiler video, it would be beneficial to have field names added to discriminated union fields. This PR is a first attempt at doing so.
I've tried to add names to a fairly limited number of types, as I wanted to get some feedback on the naming that I've used. I've used the following to decide upon the naming:
I've also tried to use the abbreviations specified in the Coding standards and idioms guide where possible, but I don't know exactly when to deviate from that.
Let me know if this PR is headed in the right direction, or if this needs work.