[WIP] FSharpQA tests migration to xUnit suite - Part 1/? #10415
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsyme
reviewed
Nov 10, 2020
| @@ -58,7 +204,4 @@ | |||
| <ProjectReference Include="$(FSharpTestsRoot)\FSharp.Test.Utilities\FSharp.Test.Utilities.fsproj" /> | |||
There was a problem hiding this comment.
These tests can directly use FSharp.Compiler.Service.fsproj, and the test project can be included in FSharp.Compiler.Service.sln if not there already
dsyme
reviewed
Nov 10, 2020
| @@ -19,9 +19,10 @@ | |||
| </ItemGroup> | |||
There was a problem hiding this comment.
These tests can run just on netcoreapp3.1. We have enough coverage on net472 through visual studio tests and other test/fsharp tests
There was a problem hiding this comment.
@dsyme This is the fsharpqa suite. For sure they run on desktop, if we can't make them run net472 then we are doing something wrong.
vzarytovskii
changed the title
|
I've significantly reduced tests migrated to the xunit - only test which don't require running or IL comparisons. Migraing them in smaller batches makes troubleshooting so much easier. |
KevinRansom
approved these changes
Dec 4, 2020
vzarytovskii
added a commit
that referenced
this pull request
Dec 5, 2020
)" This reverts commit 67b936f.
ScottHutchinson
pushed a commit
to ScottHutchinson/fsharp
that referenced
this pull request
Dec 8, 2020
…net#10415)" This reverts commit 67b936f.
nosami
pushed a commit
to xamarin/visualfsharp
that referenced
this pull request
Feb 23, 2021
* [WIP] F#QA tests (semi-)auto migration. * More IL cleanup in checker * Removed already migrated tests * Fixed some lst files format * Component tests fsproj changes * Component tests fsproj changes * Moved test file according to its name in the env list * Moved test file according to its name in the env list * Moved test file according to its name in the env list * Moved test file according to its name in the env list * Moved test file according to its name in the env list * Moved test file according to its name in the env list * Moved test file according to its name in the env list * Added 'Include' support for DirectoryAttribute * Added a bunch of functions asserting diagnostics and run ouput against pattern * Fix a bunch of F#QA tests (Expect -> Expects) * Fix a bunch of F#QA tests (file name typos) * Fix a bunch of F#QA tests (file name typos) * Fix a bunch of F#QA tests (removed missing tests from env.lst) * Added singleline regex option when matchin stderr/stdout * Don't check overall issues count when just comparing code * Removed some non-needed functionality from test fwk * Fixed F#QA test name according to env.lst * Builds + most of the tests passing * Added 'times' tests * Revert test changes * added asFsx helper * Added helper functions to Compiler testing framework * Revert test changes * Compiler testing helper functions * Reduced migrated tests to only tests we compile (don't run or compare IL) * Added missing 'times' tests * Fixed a regex for IL cleanup
nosami
pushed a commit
to xamarin/visualfsharp
that referenced
this pull request
Feb 23, 2021
…net#10415)" This reverts commit 67b936f.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a (semi-)automatic migration of F#QA tests to xUnit suite.
This PR is migrating only small fraction of simpler tests, which do not require running, IL comparison, or linking other libs - to test the migration script.
After this one is passing, I will start migrating other batches.