build.cmd fails when latest int preview of dev17 is installed

[vzarytovskii]

It builds fine from latest public VS2022 developer shell.

Build FAILED.

C:\Users\vlza\code\fsharp\vsintegration\src\FSharp.ProjectSystem.Base\FSharp.ProjectSystem.Base.csproj : error NU1504: Duplicate 'PackageReference' items found. Remove the duplicate items or use the Update functi
onality to ensure a consistent restore behavior. The duplicate 'PackageReference' items are: Microsoft.VisualStudio.ProjectAggregator 17.0.0-previews-4-31709-430, Microsoft.VisualStudio.ProjectAggregator 17.0.0-p
reviews-4-31709-430.
C:\Users\vlza\code\fsharp\vsintegration\tests\UnitTests\VisualFSharp.UnitTests.fsproj : error NU1504: Duplicate 'PackageReference' items found. Remove the duplicate items or use the Update functionality to ensure
 a consistent restore behavior. The duplicate 'PackageReference' items are: Microsoft.Build.Framework 17.0.0, Microsoft.Build.Framework 17.0.0; System.Runtime.CompilerServices.Unsafe 5.0.0, System.Runtime.Compile
rServices.Unsafe 5.0.0; NUnit 3.13.2, NUnit 3.13.2.
C:\Users\vlza\code\fsharp\vsintegration\tests\UnitTests\VisualFSharp.UnitTests.fsproj : error NU1504: Duplicate 'PackageReference' items found. Remove the duplicate items or use the Update functionality to ensure
 a consistent restore behavior. The duplicate 'PackageReference' items are: Microsoft.Build.Framework 17.0.0, Microsoft.Build.Framework 17.0.0; System.Runtime.CompilerServices.Unsafe 5.0.0, System.Runtime.Compile
rServices.Unsafe 5.0.0; NUnit 3.13.2, NUnit 3.13.2.
C:\Users\vlza\code\fsharp\vsintegration\src\FSharp.ProjectSystem.PropertyPages\FSharp.ProjectSystem.PropertyPages.vbproj : error NU1504: Duplicate 'PackageReference' items found. Remove the duplicate items or use
 the Update functionality to ensure a consistent restore behavior. The duplicate 'PackageReference' items are: System.Reflection.Metadata 5.0.0, System.Reflection.Metadata 5.0.0.
C:\Users\vlza\code\fsharp\src\fsharp\fsi\fsi.fsproj : error NU1504: Duplicate 'PackageReference' items found. Remove the duplicate items or use the Update functionality to ensure a consistent restore behavior. Th
e duplicate 'PackageReference' items are: System.Diagnostics.Process 4.3.0, System.Diagnostics.Process 4.3.0; System.Linq.Expressions 4.3.0, System.Linq.Expressions 4.3.0; System.Reflection.Emit 4.3.0, System.Ref
lection.Emit 4.3.0; System.Reflection.TypeExtensions 4.3.0, System.Reflection.TypeExtensions 4.3.0; System.Reflection.Metadata 5.0.0, System.Reflection.Metadata 5.0.0; System.Runtime.Loader 4.3.0, System.Runtime.
Loader 4.3.0; System.Security.Principal 4.3.0, System.Security.Principal 4.3.0; System.Threading.Thread 4.3.0, System.Threading.Thread 4.3.0.
C:\Users\vlza\code\fsharp\src\fsharp\fsi\fsi.fsproj : error NU1504: Duplicate 'PackageReference' items found. Remove the duplicate items or use the Update functionality to ensure a consistent restore behavior. Th
e duplicate 'PackageReference' items are: System.Diagnostics.Process 4.3.0, System.Diagnostics.Process 4.3.0; System.Linq.Expressions 4.3.0, System.Linq.Expressions 4.3.0; System.Reflection.Emit 4.3.0, System.Ref
lection.Emit 4.3.0; System.Reflection.TypeExtensions 4.3.0, System.Reflection.TypeExtensions 4.3.0; System.Reflection.Metadata 5.0.0, System.Reflection.Metadata 5.0.0; System.Runtime.Loader 4.3.0, System.Runtime.
Loader 4.3.0; System.Security.Principal 4.3.0, System.Security.Principal 4.3.0; System.Threading.Thread 4.3.0, System.Threading.Thread 4.3.0.
C:\Users\vlza\code\fsharp\vsintegration\tests\UnitTests\VisualFSharp.UnitTests.fsproj : error NU1504: Duplicate 'PackageReference' items found. Remove the duplicate items or use the Update functionality to ensure
 a consistent restore behavior. The duplicate 'PackageReference' items are: Microsoft.Build.Framework 17.0.0, Microsoft.Build.Framework 17.0.0; System.Runtime.CompilerServices.Unsafe 5.0.0, System.Runtime.Compile
rServices.Unsafe 5.0.0; NUnit 3.13.2, NUnit 3.13.2.
C:\Users\vlza\code\fsharp\vsintegration\src\FSharp.ProjectSystem.PropertyPages\FSharp.ProjectSystem.PropertyPages.vbproj : error NU1504: Duplicate 'PackageReference' items found. Remove the duplicate items or use
 the Update functionality to ensure a consistent restore behavior. The duplicate 'PackageReference' items are: System.Reflection.Metadata 5.0.0, System.Reflection.Metadata 5.0.0.
C:\Users\vlza\code\fsharp\vsintegration\src\FSharp.ProjectSystem.Base\FSharp.ProjectSystem.Base.csproj : error NU1504: Duplicate 'PackageReference' items found. Remove the duplicate items or use the Update functi
onality to ensure a consistent restore behavior. The duplicate 'PackageReference' items are: Microsoft.VisualStudio.ProjectAggregator 17.0.0-previews-4-31709-430, Microsoft.VisualStudio.ProjectAggregator 17.0.0-p
reviews-4-31709-430.
C:\Users\vlza\code\fsharp\src\fsharp\fsi\fsi.fsproj : error NU1504: Duplicate 'PackageReference' items found. Remove the duplicate items or use the Update functionality to ensure a consistent restore behavior. Th
e duplicate 'PackageReference' items are: System.Diagnostics.Process 4.3.0, System.Diagnostics.Process 4.3.0; System.Linq.Expressions 4.3.0, System.Linq.Expressions 4.3.0; System.Reflection.Emit 4.3.0, System.Ref
lection.Emit 4.3.0; System.Reflection.TypeExtensions 4.3.0, System.Reflection.TypeExtensions 4.3.0; System.Reflection.Metadata 5.0.0, System.Reflection.Metadata 5.0.0; System.Runtime.Loader 4.3.0, System.Runtime.
Loader 4.3.0; System.Security.Principal 4.3.0, System.Security.Principal 4.3.0; System.Threading.Thread 4.3.0, System.Threading.Thread 4.3.0.
    0 Warning(s)
    10 Error(s)

Time Elapsed 00:03:34.67

[KevinRansom]

Do we think this is an issue with our repo or arcade or the dotnet sdk?

[baronfel]

We have this in the SDK itself, too - NuGet added some new features for detecting cycles in this spec. These particular errors are likely due to SDK targets, and we may incidentally end up fixing them as part of dotnet/sdk#24747. I need to triage that one soon. As you can see from the linked SDK issue, tons of MS repos are disabling the warning until we fix it.

[vzarytovskii]

Okay I will disable this warning for the time being.

[vzarytovskii]

Workaround merged in #13055

[vzarytovskii]

We got another batch of issues, this time mostly in vsintegration:

error NU1504: Duplicate 'PackageReference' items found. Remove the duplicate item
s or use the Update functionality to ensure a consistent restore behavior. The duplicate 'PackageReference' items are: System.Runtime.CompilerServices.Unsafe 6.0.0, System.Runtim
e.CompilerServices.Unsafe 6.0.0.

FYI @baronfel
Also, it's different error - nu1504 vs nu1505 mentioned in dotnet/sdk#24747

[baronfel]

Couple quick notes, will update as I see things:

• System.Runtime.CompilerServices.Unsafe error is because of these two duplicate references, which should be consolidated
• FSharp.ProjectSystem.Base.csproj does have duplicate PackageReference items for Microsoft.VisualStudio.ProjectAggregator, also an easy fix
• VisualFSharp.UnitTests.fsproj are duplicate as well - both the fsproj and the vsintegration/Directory.Build.targets have the Microsoft.Build.Framework PackageReference in them. Possibly some build logic needs to change here on your part
  • the NoMsbuild condition doesn't seem to be used anywhere - so I think these references are just universal
• FSharp.ProjectSystem.PropertyPages.vbproj - same thing, duplicated PackageReferences between the project file and the vsintegration/Directory.Build.targets
• Fsi.fsproj - duplicate packagereferences in the project file here too.