Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

moving to different command structure #1276

Merged
merged 21 commits into from
Sep 1, 2021

Conversation

jmarolf
Copy link
Contributor

@jmarolf jmarolf commented Aug 18, 2021

This will require similar change to the dotnet/sdk repo once this is merged.

@jmarolf jmarolf changed the base branch from main to release/6.x August 25, 2021 00:25
@jmarolf jmarolf marked this pull request as ready for review August 25, 2021 00:30
@jmarolf
Copy link
Contributor Author

jmarolf commented Aug 25, 2021

@JoeRobich I am merging main to release/6.x to clean up the changes a bit. May want to wait to review this until then.

One wild change I am making is having the 6.0 release target .NET 6. Let me know if there are giant unforseen problem here.

@jmarolf jmarolf force-pushed the feature/update-cli-to-match-sdk branch from ac7af98 to 3700694 Compare August 25, 2021 04:33
@JoeRobich
Copy link
Member

One wild change I am making is having the 6.0 release target .NET 6. Let me know if there are giant unforseen problem here.

One downside is anyone using still using dotnet-format as a global tool with .NET 3.1 or .NET 5 will need to stick with the 5.x release. If we decide to keep the change, we may want to publish an updated 5.x with a newer Roslyn compiler.

@jmarolf
Copy link
Contributor Author

jmarolf commented Aug 25, 2021

If we decide to keep the change, we may want to publish an updated 5.x with a newer Roslyn compiler.

My preference would be to not continue to support older versions. We just ship the SDK and simplify the support structure (i.e. we only support running on the SDK we insert into).

@JoeRobich
Copy link
Member

we only support running on the SDK we insert into

K then we will need to tweak the how we use MSBuildLocator. Currently it will try and load the SDK that is pinned in the global.json, and this branch falls over if that is 3.1 or 5.0.

@jmarolf
Copy link
Contributor Author

jmarolf commented Aug 25, 2021

K then we will need to tweak the how we use MSBuildLocator. Currently it will try and load the SDK that is pinned in the global.json, and this branch falls over if that is 3.1 or 5.0.

Got it. I think we don't want to support that anymore for the tool that is installed in the SDK.

@JoeRobich JoeRobich force-pushed the feature/update-cli-to-match-sdk branch from 660695d to 359c39d Compare August 26, 2021 02:44
@JoeRobich
Copy link
Member

@jmarolf Any reason to hold on merging this?

@jmarolf jmarolf merged commit 9629a48 into dotnet:release/6.x Sep 1, 2021
@jmarolf jmarolf deleted the feature/update-cli-to-match-sdk branch September 1, 2021 03:55
@mihai-unity
Copy link

I just noticed this PR lost -f alias for --folder.

@JoeRobich
Copy link
Member

@mihai-unity Yes, this was an intentional breaking change taken to better incorporate into the dotnet CLI. Breaking changes are being tracked on issue #1292.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants