-
Notifications
You must be signed in to change notification settings - Fork 172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
moving to different command structure #1276
moving to different command structure #1276
Conversation
@JoeRobich I am merging main to release/6.x to clean up the changes a bit. May want to wait to review this until then. One wild change I am making is having the 6.0 release target .NET 6. Let me know if there are giant unforseen problem here. |
ac7af98
to
3700694
Compare
One downside is anyone using still using dotnet-format as a global tool with .NET 3.1 or .NET 5 will need to stick with the 5.x release. If we decide to keep the change, we may want to publish an updated 5.x with a newer Roslyn compiler. |
My preference would be to not continue to support older versions. We just ship the SDK and simplify the support structure (i.e. we only support running on the SDK we insert into). |
K then we will need to tweak the how we use MSBuildLocator. Currently it will try and load the SDK that is pinned in the global.json, and this branch falls over if that is 3.1 or 5.0. |
Got it. I think we don't want to support that anymore for the tool that is installed in the SDK. |
660695d
to
359c39d
Compare
@jmarolf Any reason to hold on merging this? |
I just noticed this PR lost |
@mihai-unity Yes, this was an intentional breaking change taken to better incorporate into the dotnet CLI. Breaking changes are being tracked on issue #1292. |
This will require similar change to the dotnet/sdk repo once this is merged.