Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure Ollama streaming updates specify a CompletionId. #5795

Merged
merged 2 commits into from
Jan 14, 2025

Conversation

eiriktsarpalis
Copy link
Member

@eiriktsarpalis eiriktsarpalis commented Jan 14, 2025

Discovered while working on eiriktsarpalis/blackbeard-extension-cs#1. Non-streaming completions use the CreatedAt timestamp as the completion id, however this is being omitted for the case of streaming completions.

Microsoft Reviewers: Open in CodeFlow

@eiriktsarpalis eiriktsarpalis requested a review from a team as a code owner January 14, 2025 11:45
@eiriktsarpalis eiriktsarpalis enabled auto-merge (squash) January 14, 2025 11:45
@dotnet-comment-bot
Copy link
Collaborator

🎉 Good job! The coverage increased 🎉
Update MinCodeCoverage in the project files.

Project Expected Actual
Microsoft.Extensions.AI 88 89

Full code coverage report: https://dev.azure.com/dnceng-public/public/_build/results?buildId=916794&view=codecoverage-tab

@dotnet-comment-bot
Copy link
Collaborator

‼️ Found issues ‼️

Project Coverage Type Expected Actual
Microsoft.Extensions.Caching.Hybrid Line 86 78.07 🔻

🎉 Good job! The coverage increased 🎉
Update MinCodeCoverage in the project files.

Project Expected Actual
Microsoft.Extensions.AI.OpenAI 77 78
Microsoft.Extensions.AI 88 89

Full code coverage report: https://dev.azure.com/dnceng-public/public/_build/results?buildId=917062&view=codecoverage-tab

@eiriktsarpalis eiriktsarpalis merged commit b26772a into dotnet:main Jan 14, 2025
6 checks passed
@eiriktsarpalis eiriktsarpalis deleted the ollama-add-completionid branch January 14, 2025 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants