Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix schema generation for floating point types #5788

Merged
merged 2 commits into from
Jan 10, 2025
Merged

Fix schema generation for floating point types #5788

merged 2 commits into from
Jan 10, 2025
+33 −20

Conversation

eiriktsarpalis
Copy link
Member

@eiriktsarpalis eiriktsarpalis commented Jan 10, 2025 •
edited by dotnet-policy-service bot
Loading

Fix #5787.

Microsoft Reviewers: Open in CodeFlow

@eiriktsarpalis eiriktsarpalis requested a review from a team as a code owner January 10, 2025 13:57
SteveSandersonMS
SteveSandersonMS approved these changes Jan 10, 2025
View reviewed changes
Copy link
Member

@SteveSandersonMS SteveSandersonMS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks!

@eiriktsarpalis eiriktsarpalis enabled auto-merge (squash) January 10, 2025 14:35
@dotnet-comment-bot
Copy link
Collaborator

🎉 Good job! The coverage increased 🎉
Update MinCodeCoverage in the project files.

Project Expected Actual
Microsoft.Extensions.AI 88 89

Full code coverage report: https://dev.azure.com/dnceng-public/public/_build/results?buildId=913370&view=codecoverage-tab

@eiriktsarpalis eiriktsarpalis merged commit b86638d into dotnet:main Jan 10, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stephentoub stephentoub stephentoub approved these changes

@SteveSandersonMS SteveSandersonMS SteveSandersonMS approved these changes

Assignees

@eiriktsarpalis eiriktsarpalis

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Structured output schema generation is too loose for decimal/double/float
4 participants
@eiriktsarpalis @dotnet-comment-bot @SteveSandersonMS @stephentoub