Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix hashing in Logging source gen #5776

Merged
merged 1 commit into from
Jan 6, 2025
Merged

Fix hashing in Logging source gen #5776

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions src/Generators/Microsoft.Gen.Logging/Emission/Emitter.Method.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -155,7 +155,8 @@ static int GetNonRandomizedHashCode(string s)
result = (c ^ result) * Mult;
}

return Math.Abs((int)result);
const uint NegativeMask = 0x7FFFFFFF;
return (int)(result & NegativeMask); // Ensure the result is non-negative
}

static bool ShouldStringifyParameter(LoggingMethodParameter p)
Expand All @@ -174,7 +175,7 @@ static bool ShouldStringifyParameter(LoggingMethodParameter p)

if (!p.Type.Contains("."))
{
// no . means this is a primitive type, pass as-is
// no . means this is a primitive type, pass as-is
return false;
}

Expand All @@ -198,7 +199,7 @@ static bool ShouldStringifyProperty(LoggingProperty p)

if (!p.Type.Contains("."))
{
// no . means this is a primitive type, pass as-is
// no . means this is a primitive type, pass as-is
return false;
}

Expand Down