Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix a few issues in IChatClient implementations #5549

Merged
merged 2 commits into from
Oct 22, 2024
Merged

Fix a few issues in IChatClient implementations #5549

merged 2 commits into from
Oct 22, 2024

Commits on Oct 22, 2024

  1. Fix a few issues in IChatClient implementations 

    - Avoid null arg exception when constructing system message with null text
- Avoid empty exception when constructing user message with no parts
- Use all parts rather than just first text part for system message
- Handle assistant messages with both content and tools
- Avoid unnecessarily trying to weed out duplicate call ids
    @stephentoub
    stephentoub committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    787b84c View commit details
    Browse the repository at this point in the history

  2. Address PR feedback 

    - Normalize null to string.Empty in TextContent
- Ensure GetContentParts always produces at least one part, even if empty text content
    @stephentoub
    stephentoub committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    e93f1e6 View commit details
    Browse the repository at this point in the history