Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove AIContent.ModelId, add StreamingChatCompletionUpdate.ModelId #5535

Merged
merged 2 commits into from
Oct 22, 2024

Conversation

stephentoub
Copy link
Member

@stephentoub stephentoub commented Oct 18, 2024

Closes #5529

This is a source and binary break. We should discuss when best to merge, and merge other similar breaks at the same time. We've had a few discussions about ctors to remove and things like that.
cc: @SteveSandersonMS, @eiriktsarpalis

Microsoft Reviewers: Open in CodeFlow

@stephentoub stephentoub requested a review from a team as a code owner October 18, 2024 03:15
@eiriktsarpalis eiriktsarpalis added the * NO MERGE * Do not merge this PR as long as this label is present. label Oct 18, 2024
@luisquintanilla
Copy link
Contributor

@stephentoub I think I get this change for streaming scenarios. Not sure if I missed it but I don't see how the model ID is exposed for non-streaming scenarios.

@luisquintanilla
Copy link
Contributor

@stephentoub I think I get this change for streaming scenarios. Not sure if I missed it but I don't see how the model ID is exposed for non-streaming scenarios.

Disregard 🙂 . I see it's in the client ctor.

@stephentoub
Copy link
Member Author

I don't see how the model ID is exposed for non-streaming scenarios.

/// <summary>Gets or sets the model ID using in the creation of the chat completion.</summary>
public string? ModelId { get; set; }

@stephentoub stephentoub removed the * NO MERGE * Do not merge this PR as long as this label is present. label Oct 22, 2024
@stephentoub stephentoub merged commit 651546f into dotnet:main Oct 22, 2024
6 checks passed
@stephentoub stephentoub deleted the fixupmodelid branch October 22, 2024 01:52
@github-actions github-actions bot locked and limited conversation to collaborators Nov 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Revisit AIContent.ModelId
3 participants