Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace Network Type string with Const in ResourceMonitoring #5398

Merged
merged 2 commits into from
Sep 3, 2024

Conversation

makazeu
Copy link
Contributor

@makazeu makazeu commented Sep 3, 2024

There are 2 occurances for network.type as metry key in ResourceMonitoring's WindowsNetworkMetrics and LinuxNetworkMetrics classes.
We can replace them as a const string.

Microsoft Reviewers: Open in CodeFlow

@evgenyfedorov2
Copy link
Contributor

@makazeu
Copy link
Contributor Author

makazeu commented Sep 3, 2024

@makazeu please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.

@dotnet-policy-service agree [company="{your company}"]

Options:

  • (default - no company specified) I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer.
@dotnet-policy-service agree
  • (when company given) I am making Submissions in the course of work for my employer (or my employer has intellectual property rights in my Submissions by contract or applicable law). I have permission from my employer to make Submissions and enter into this Agreement on behalf of my employer. By signing below, the defined term “You” includes me and my employer.
@dotnet-policy-service agree company="Microsoft"

Contributor License Agreement

@dotnet-policy-service agree

@makazeu
Copy link
Contributor Author

makazeu commented Sep 3, 2024

Can anyone help re-run the failed checks? Thanks!

@RussKie RussKie merged commit 45e8ca3 into dotnet:main Sep 3, 2024
6 checks passed
@RussKie
Copy link
Member

RussKie commented Sep 3, 2024

Thank you

@makazeu makazeu deleted the u/makazeu/NetworkTypeKeyStringConst branch September 3, 2024 13:31
@github-actions github-actions bot locked and limited conversation to collaborators Oct 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants