-
Notifications
You must be signed in to change notification settings - Fork 758
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate IResourceUtilizationPublisher #5360
Deprecate IResourceUtilizationPublisher #5360
Conversation
src/Libraries/Microsoft.Extensions.Diagnostics.ResourceMonitoring/IResourceMonitorBuilder.cs
Outdated
Show resolved
Hide resolved
Based on the feedback, I suggest the following course of action:
|
The new "obsoletion" code naming convention is up for a debate. Thoughts/ideas/suggestions? /cc: @joperezr |
I don't really have any preference. I'd just look at precedent in case runtime or aspnetcore have special conventions for these, and if not then just do what we would've done for a regular diagnostic id. |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's a little more work to be done, but overall looks good. 👍
Thank you |
Please add a link to the docs update PR, when you have it. |
Fixes #4404.
Deprecating the
IResourceUtilizationPublisher
interface as per the mentioned issue. Consequences:ResourceUtilizationInstruments
class. This is the recommended way to consume the resource utilization data.IResourceMonitor
interface.After retiring of
IResourceUtilizationPublisher
, theResourceMonitorBuilder
class, as well as the respective interfaceIResourceMonitorBuilder
, both do not bring much value. Happy to discuss if it makes sense to deprecate them too.Microsoft Reviewers: Open in CodeFlow