Add tsaconfig #5285
Merged
Add tsaconfig #5285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danmoseley
added
the
* NO MERGE *
joperezr
approved these changes
Jul 17, 2024
There was a problem hiding this comment.
LGTM, thanks for getting this done @danmoseley!
Regarding the rename of CredScanSuppressions, I'm assuming this is following 1ES guidelines of where they should be located at?
|
Can you enable policheck in the 1ES templates with this PR? |
|
Added. Jose after this goes in you'll want to check that all the right tools and things run.. |
Yeah, one thing we can do is before merging, we can trigger an internal build from your branch and then do a diff to make sure all the right steps are still running. |
|
I'll let you do that since you are probably a better person to interpret it.. |
danmoseley
added
area-infrastructure
and removed
* NO MERGE *
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Microsoft Reviewers: Open in CodeFlow