Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ci] Enable source-indexer on internal pipeline for windows #5274

Merged
merged 1 commit into from
Jul 9, 2024
Merged

[ci] Enable source-indexer on internal pipeline for windows #5274

merged 1 commit into from
Jul 9, 2024

Conversation

radical
Copy link
Member

@radical radical commented Jul 9, 2024 •
edited by dotnet-policy-service bot
Loading

Microsoft Reviewers: Open in CodeFlow

@radical radical requested a review from RussKie July 9, 2024 05:42
@radical radical force-pushed the source-index branch 2 times, most recently from 53ed588 to c0cd5c7 Compare July 9, 2024 07:43
@radical radical marked this pull request as ready for review July 9, 2024 08:27
@radical radical requested a review from danmoseley July 9, 2024 08:28
@radical
Copy link
Member Author

radical commented Jul 9, 2024

Working step on the internal pipeline - https://dev.azure.com/dnceng/internal/_build/results?buildId=2491116&view=logs&s=6884a131-87da-5381-61f3-d7acc3b91d76&j=316d5c15-0c50-544e-8051-e6b14a1ab674

@RussKie
Copy link
Member

RussKie commented Jul 9, 2024

Working step on the internal pipeline - dev.azure.com/dnceng/internal/_build/results?buildId=2491116&view=logs&s=6884a131-87da-5381-61f3-d7acc3b91d76&j=316d5c15-0c50-544e-8051-e6b14a1ab674

Is it worth running full internal CI to verify it won't upset anything?

@radical
Copy link
Member Author

radical commented Jul 9, 2024

Working step on the internal pipeline - dev.azure.com/dnceng/internal/_build/results?buildId=2491116&view=logs&s=6884a131-87da-5381-61f3-d7acc3b91d76&j=316d5c15-0c50-544e-8051-e6b14a1ab674

Is it worth running full internal CI to verify it won't upset anything?

No harm in waiting for a full run.

@radical radical mentioned this pull request Jul 9, 2024
Merged
@radical
Copy link
Member Author

radical commented Jul 9, 2024

New run - https://dev.azure.com/dnceng/internal/_build/results?buildId=2491134&view=results .

Feel free to merge this, and the dotnet/source-indexer#160 if the build completes without issues.

@radical radical merged commit 77bfd66 into dotnet:main Jul 9, 2024
6 checks passed
@radical radical deleted the source-index branch July 9, 2024 19:09
@radical radical mentioned this pull request Jul 10, 2024
Closed
@github-actions github-actions bot locked and limited conversation to collaborators Aug 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@RussKie RussKie RussKie approved these changes

@danmoseley danmoseley Awaiting requested review from danmoseley

Assignees

@radical radical

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@radical @RussKie