Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Trim dependencies #5058

Merged
merged 2 commits into from
Mar 20, 2024
Merged

Trim dependencies #5058

merged 2 commits into from
Mar 20, 2024

Conversation

geeknoid
Copy link
Member

@geeknoid geeknoid commented Mar 19, 2024 •
edited by dotnet-policy-service bot
Loading

  • Enable the ReferenceTrimmer analyzer to make sure the dependencies stay clean.

Fixes #5046

Microsoft Reviewers: Open in CodeFlow

Trim dependencies
9509345 
- Enable the ReferenceTrimmer analyzer to make sure
the dependencies stay clean.

Fixes #5046
@geeknoid geeknoid requested a review from joperezr March 19, 2024 22:09
RussKie
RussKie approved these changes Mar 19, 2024
View reviewed changes
Copy link
Member

@RussKie RussKie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

src/Shared/Shared.csproj Outdated Show resolved Hide resolved
joperezr
joperezr reviewed Mar 19, 2024
View reviewed changes
Copy link
Member

@joperezr joperezr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know I've said it offline but just mentioning here too. This is a breaking change because we consider the dependencies to be part of the public contract of a package.

joperezr
joperezr reviewed Mar 19, 2024
View reviewed changes
Directory.Build.targets Outdated Show resolved Hide resolved
@geeknoid geeknoid enabled auto-merge (squash) March 20, 2024 13:27
@geeknoid geeknoid disabled auto-merge March 20, 2024 13:27
@geeknoid geeknoid merged commit 16b4066 into main Mar 20, 2024
6 checks passed
@geeknoid geeknoid deleted the geeknoid/ref branch March 20, 2024 21:48
@martincostello martincostello mentioned this pull request Apr 12, 2024
Merged
@martincostello
Copy link
Member

I know I've said it offline but just mentioning here too. This is a breaking change because we consider the dependencies to be part of the public contract of a package.

I think I just ran into this with Polly for net9.0: https://github.com/App-vNext/Polly/pull/2003/files#r1562231498

@martincostello
Copy link
Member

Actually, it's affecting net8.0 too if I update to 8.4.0: failed build

@martincostello martincostello mentioned this pull request Apr 12, 2024
Closed
@github-actions github-actions bot locked and limited conversation to collaborators May 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@joperezr joperezr joperezr left review comments

@RussKie RussKie RussKie approved these changes

Assignees

@geeknoid geeknoid

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Consider removing package references for inbox assemblies
4 participants
@geeknoid @martincostello @RussKie @joperezr