Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup to skip/flaky attributes #2186

Merged
merged 4 commits into from
Aug 15, 2019
Merged

Cleanup to skip/flaky attributes #2186

merged 4 commits into from
Aug 15, 2019

Conversation

jkotalik
Copy link

@jkotalik jkotalik commented Aug 14, 2019 •
edited
Loading

  • Moves SkipOnHelix to M.A.Testing
  • Adds SkipOnCI
  • Change namespaces to have everything in the same namespace (FlakyOn and FlakyAttribute were in a different namespace).

This is a testing only change.

@jkotalik jkotalik requested a review from Tratcher as a code owner August 14, 2019 21:03
BrennanConroy
BrennanConroy reviewed Aug 14, 2019
View reviewed changes
Copy link
Member

@BrennanConroy BrennanConroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this to remove default port tests from CI?

@jkotalik jkotalik mentioned this pull request Aug 14, 2019
Merged
@analogrelay analogrelay added this to the 3.0.0-preview9 milestone Aug 14, 2019
@jkotalik
Copy link
Author

🆙 📅

@jkotalik
Copy link
Author

@aspnet/build there will be build issues in the aspnetcore repo once this is merged. Please assignment me if I haven't started fixing it myself.

@jkotalik jkotalik merged commit cfef5e0 into release/3.0 Aug 15, 2019
@ghost ghost deleted the jkotalik/testInfraCleanup branch August 15, 2019 16:12
@wtgodbe wtgodbe mentioned this pull request Aug 28, 2019
Closed
JunTaoLuo pushed a commit to dotnet/aspnetcore that referenced this pull request Feb 12, 2020
@jkotalik
Cleanup to skip/flaky attributes (dotnet/extensions#2186)
0841c6c 
\n\nCommit migrated from dotnet/extensions@cfef5e0
JunTaoLuo pushed a commit to dotnet/aspnetcore that referenced this pull request Feb 15, 2020
@jkotalik
Cleanup to skip/flaky attributes (dotnet/extensions#2186)
c717230 
\n\nCommit migrated from dotnet/extensions@cfef5e0
maryamariyan pushed a commit to maryamariyan/runtime that referenced this pull request Feb 28, 2020
@jkotalik
Cleanup to skip/flaky attributes (dotnet/extensions#2186)
234b098 
Commit migrated from dotnet/extensions@cfef5e0
maryamariyan pushed a commit to maryamariyan/runtime that referenced this pull request Mar 2, 2020
@jkotalik
Cleanup to skip/flaky attributes (dotnet/extensions#2186)
6f29e7d 
Commit migrated from dotnet/extensions@cfef5e0
maryamariyan pushed a commit to maryamariyan/runtime that referenced this pull request Mar 11, 2020
@jkotalik
Cleanup to skip/flaky attributes (dotnet/extensions#2186)
8068d5a 
Commit migrated from dotnet/extensions@cfef5e0
maryamariyan pushed a commit to maryamariyan/runtime that referenced this pull request Mar 11, 2020
@jkotalik
Cleanup to skip/flaky attributes (dotnet/extensions#2186)
03453fb 
Commit migrated from dotnet/extensions@cfef5e0
maryamariyan pushed a commit to maryamariyan/runtime that referenced this pull request Mar 25, 2020
@jkotalik
Cleanup to skip/flaky attributes (dotnet/extensions#2186)
1e20305 
Commit migrated from dotnet/extensions@cfef5e0
maryamariyan pushed a commit to maryamariyan/runtime that referenced this pull request Mar 27, 2020
@jkotalik
Cleanup to skip/flaky attributes (dotnet/extensions#2186)
5108931 
Commit migrated from dotnet/extensions@cfef5e0
JunTaoLuo pushed a commit to dotnet/aspnetcore that referenced this pull request Nov 17, 2020
@jkotalik
Cleanup to skip/flaky attributes (dotnet/extensions#2186)
7bc8e1a 
\n\nCommit migrated from dotnet/extensions@cfef5e0
@ghost ghost locked as resolved and limited conversation to collaborators May 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@BrennanConroy BrennanConroy BrennanConroy approved these changes

@analogrelay analogrelay Awaiting requested review from analogrelay

@Tratcher Tratcher Awaiting requested review from Tratcher

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.0.0-preview9
Development

Successfully merging this pull request may close these issues.
3 participants
@jkotalik @BrennanConroy @analogrelay