You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
var meter = meterFactory.Create(nameof(ResourceMonitoring));
This library has 2 different meters, which is confusing to users.
Reproduction Steps
Just use the library.
_ = services.AddResourceMonitoring();
Expected behavior
Both WindowsContainerSnapshotProvider.cs and WindowsNetworkMetrics.cs should use the same meter name, which is Microsoft.Extensions.Diagnostics.ResourceMonitoring.
Actual behavior
WindowsContainerSnapshotProvider.cs uses the meter name Microsoft.Extensions.Diagnostics.ResourceMonitoring while WindowsNetworkMetrics.cs uses a different meter name ResourceMonitoring.
Regression?
No response
Known Workarounds
if we only enable selected meters when collecting metrics, add the ResourceMonitoring one which we are likely miss.
Configuration
No response
Other information
No response
The text was updated successfully, but these errors were encountered:
Description
In WindowsContainerSnapshotProvider.cs, the meter name is
Microsoft.Extensions.Diagnostics.ResourceMonitoring
.But in WindowsNetworkMetrics.cs, the meter name is
ResourceMonitoring
.This library has 2 different meters, which is confusing to users.
Reproduction Steps
Just use the library.
Expected behavior
Both
WindowsContainerSnapshotProvider.cs
andWindowsNetworkMetrics.cs
should use the same meter name, which isMicrosoft.Extensions.Diagnostics.ResourceMonitoring
.Actual behavior
WindowsContainerSnapshotProvider.cs
uses the meter nameMicrosoft.Extensions.Diagnostics.ResourceMonitoring
whileWindowsNetworkMetrics.cs
uses a different meter nameResourceMonitoring
.Regression?
No response
Known Workarounds
if we only enable selected meters when collecting metrics, add the
ResourceMonitoring
one which we are likely miss.Configuration
No response
Other information
No response
The text was updated successfully, but these errors were encountered: