Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix TreatPreviousAsCurrent check #1083

Merged
merged 1 commit into from
Jan 30, 2025
Merged

Conversation

maraf
Copy link
Member

@maraf maraf commented Jan 30, 2025

The TreatPreviousAsCurrent is currently empty, but we don't want to treat current as 9.
The possible way to ensure TreatPreviousAsCurrent is set before emscripten is imported is to move the property initialization to AutoImport.props which always imports before WorkloadManifest.targets

@maraf maraf requested review from lewing and akoeplinger January 30, 2025 12:26
@maraf maraf self-assigned this Jan 30, 2025
@akoeplinger akoeplinger enabled auto-merge (squash) January 30, 2025 13:21
@akoeplinger akoeplinger merged commit 343ebb9 into main Jan 30, 2025
13 checks passed
@maraf maraf deleted the maraf/FixTreatPreviousAsCurrent branch January 30, 2025 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants