Query: Tuples are not translatable to Sql. Client Eval them #9522
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anpete
reviewed
Aug 22, 2017
| var ids = new[] { Tuple.Create(1, 2), Tuple.Create(10248, 11) }; | ||
|
|
||
| AssertQuery<OrderDetail>( | ||
| cd => cd.Where(c => ids.Contains(new Tuple<int, int>(c.OrderID, c.ProductID))), entryCount: 1); |
There was a problem hiding this comment.
cd -> od
c -> od
What happens with normal anonymous type for this test?
There was a problem hiding this comment.
It also fails. Needs different solution.
anpete
reviewed
Aug 22, 2017
| */ | ||
| if ((!expression.Type.IsGenericType | ||
| || !string.Equals(expression.Type.GetGenericTypeDefinition().DisplayName(), typeof(Tuple).DisplayName())) | ||
| && expression.Members != null |
There was a problem hiding this comment.
Can we do the anonymous type expansion?
smitpatel
force-pushed
the
containstuple
branch
from
f990d92 to
06aeff6
Compare
|
Updated |
anpete
reviewed
Aug 22, 2017
| @@ -907,7 +907,7 @@ protected override Expression VisitSubQuery(SubQueryExpression expression) | |||
| || fromExpression.NodeType == ExpressionType.NewArrayInit) | |||
| { | |||
| var containsItem = Visit(contains.Item)?.RemoveConvert(); | |||
| if (containsItem != null) | |||
| if (containsItem != null && !containsItem.Type.Equals(typeof(Expression[]))) | |||
… not translatable to server Fixes #9424
smitpatel
force-pushed
the
containstuple
branch
from
06aeff6 to
ccb6a27
Compare
|
Added more tests. We are not translating equality in Where for anonymous/tuple. |
|
@anpete - Ping! |
anpete
approved these changes
Aug 22, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9424