Don't use a temporary table for batching inserts. #8806
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anpete
reviewed
Jun 9, 2017
| || typeName.Equals("timestamp", StringComparison.OrdinalIgnoreCase)) | ||
| ? (property.IsNullable ? "varbinary(8)" : "binary(8)") | ||
| : typeName; | ||
| if (property.ClrType == typeof(byte[]) |
There was a problem hiding this comment.
Should this be in the type mapper?
There was a problem hiding this comment.
It's very update-specific, I doubt it could be reused.
anpete
reviewed
Jun 9, 2017
| .AppendJoin( | ||
| writeOperations, | ||
| SqlGenerationHelper, | ||
| (sb, o, helper) => { helper.DelimitIdentifier(sb, o.ColumnName); }); |
|
This doesn't implement the ordering elimination optimization so we should still track that somehow. |
anpete
reviewed
Jun 9, 2017
| "DECLARE @inserted0 TABLE ([Id] int, [_Position] [int]);" + Environment.NewLine + | ||
| "MERGE [dbo].[Ducks] USING @toInsert0 AS i ON 1=0" + Environment.NewLine + | ||
| "MERGE [dbo].[Ducks] USING (" + Environment.NewLine + |
There was a problem hiding this comment.
This change only affects one SQL baseline? Do we have enough coverage for SQL gen here?
There was a problem hiding this comment.
Also, consider using verbatim strings here like we do in query - The Env.NLs add a lot of clutter.
There was a problem hiding this comment.
I believe that ideally a single change in SQL gen should require a single change in the baseline.
anpete
approved these changes
Jun 9, 2017
|
I'll keep #8415 open |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8415
Fixes #8322