Stop generating DiagnosticSource events for purely design-time messages #8750
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndriySvyryd
approved these changes
Jun 6, 2017
This means if the message is in "Scaffolding", then it is tested to not generate DiagnosticSource events. All other events are tested to be doing DiagnosticSource messages using nominal types. Issue #7939
ajcvickers
force-pushed
the
DiagWhatNow0606
branch
from
1ad8007 to
cdff2ac
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This means if the message is in "Scaffolding", then it is tested to not generate DiagnosticSource events.
All other events are tested to be doing DiagnosticSource messages using nominal types.
Issue #7939