Add EventId, LogLevel, and message generation for event payloads #8637
+2,009
−337
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anpete
reviewed
May 30, 2017
| [NotNull] Exception exception) | ||
| { | ||
| var definition = CoreStrings.LogExceptionDuringSaveChanges; | ||
|
|
||
| definition.Log( | ||
| diagnostics, | ||
| contextType, Environment.NewLine, exception, | ||
| context.GetType(), Environment.NewLine, exception, |
There was a problem hiding this comment.
Duped exception arg being passed
There was a problem hiding this comment.
Yep. I generally didn't change any of the logger messages that we generate. So where we had the exception in the message format string it is still there. I don't think there is a way to get it into the format string using the LoggerMessage facilities without including it as one of the args, meaning it gets duplicated here. But we could choose to remove it from the message if we wanted to.
anpete
approved these changes
May 30, 2017
Issue #7939 Also adds nominal types for all events other than those in the relational design assemblies. (Since these assemblies are currently being refactored.) Each event payload now contains all the information needed to create and log the message for the event, including overridden ToString that creates the message.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #7939
Also adds nominal types for all events other than those in the relational design assemblies. (Since these assemblies are currently being refactored.)
Each event payload now contains all the information needed to create and log the message for the event, including overridden ToString that creates the message.