Initial batch of nominal types for DiagnosticSource events #8351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajcvickers
force-pushed
the
NomNomTypes0429
branch
2 times, most recently
from
302de03 to
6d9a36c
Compare
anpete
approved these changes
May 3, 2017
Issue #7938, #8007 * This covers most of the relational events. * Namespace is Microsoft.EntityFrameworkCore.DiagnosticSourceData (Didn't use xxx.xxx.DiagnosticSource as a namespace because then there is a namespace with the same name as a class causing resolution niceness issues.) * Created something of a hierarchy where it made sense so that common code can be used by consumers in some places and to be a bit more DRY. * Tried to be somewhat consistent in ordering, etc. * Made sure ConnectionId and CommandId are exposed where available, specifically including on DataReaderDisposing as requested in #8007.
ajcvickers
force-pushed
the
NomNomTypes0429
branch
from
6d9a36c to
2c4af12
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #7939, #8007