Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix globalization issues #5879

Merged
merged 1 commit into from
Jun 28, 2016
Merged

Fix globalization issues #5879

merged 1 commit into from
Jun 28, 2016

Conversation

ajcvickers
Copy link
Contributor

Issue #5765

@lajones
Copy link
Contributor

lajones commented Jun 27, 2016

Looks good. Rather than just the comment // Interpolation OK..., is there any better way of indicating that the code as written should be ignored as far as the globalization checks are concerned? An annotation perhaps (depends on what tool we run to detect the problem in the first place I guess)? If not then :shipit:

@ajcvickers
Copy link
Contributor Author

@lajones I'll leave it to @bricelam to comment on what he is using and whether there is a way to suppress warnings.

@ajcvickers ajcvickers merged commit 0bae43d into dev Jun 28, 2016
@bricelam
Copy link
Contributor

#pragma disable or [SuppressMessage] will work, but I don't think it's important until we actually automate the checks.

@bricelam bricelam deleted the Glob5765 branch August 8, 2016 16:15
Eilon
Eilon reviewed Aug 8, 2016
View reviewed changes
src/Microsoft.EntityFrameworkCore.Design.Core/Properties/DesignCoreStrings.resx
@@ -255,4 +255,7 @@ Change your target project to the migrations project by using the Package Manage
<data name="InvokeStartupMethodFailed" xml:space="preserve">
<value>An error occurred while calling method '{method}' on startup class '{startupClass}'. Consider using IDbContextFactory to override the initialization of the DbContext at design-time. Error: {error}</value>
</data>
<data name="CouldNotSerialize " xml:space="preserve">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bricelam there's a trailing space in the key here. Can we fix that?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(I realize it probably has no effect, but just in case.)

@smitpatel smitpatel mentioned this pull request Mar 18, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ajcvickers @lajones @bricelam @Eilon @dnfclas