Fix #5376 - escape parameters passed to dotnet-ef from PMC #5618
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } | ||
| throw $verboseOutput | ||
| throw $stderr |
There was a problem hiding this comment.
What happens if there is no stderr? I.e. does this need if ($stderr) { ... } around it?
There was a problem hiding this comment.
See line above. I could remove -and $stdout from the predicate because that is always true...
There was a problem hiding this comment.
Let me put it another way - what happens if both stderr and stdout are empty? Does the call at line 704 error?
There was a problem hiding this comment.
I suppose it would, but I do not know of any case when a call to dotnet returns with a non-zero exit code an has no output on either stderr or stdout
There was a problem hiding this comment.
OK. I'd rather issue an error message in that scenario, but that's not the main point of this fix.
|
|
natemcmaster
pushed a commit
to dotnet/EntityFramework.Docs
that referenced
this pull request
Jun 29, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @lajones @bricelam
This also fixes out we treat verbose output and stderr.
Escapes all parameters passed to dotnet-ef with single quotes.