Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI commands on desktop: resolve startup assembly from external project #5286

Closed
wants to merge 2 commits into from

Conversation

natemcmaster
Copy link
Contributor

Partial fix for #4577

This is the minimal change we can make that will enable most users to use dotnet-ef for desktop .NET. Although the implementation will other issues for some users, I believe this is a good tradeoff to the high cost of fixing #4577 perfectly.

Why it's not perfect (simplifed): this tries to pull a "child" assembly into a "parent" app domain. The child may have dependencies that conflicts with the "parent" app domain. Should this problem arise (which may not for most users), the solution is to lift dependencies in the project.json for the "child" assembly.

The "proper" way to do this (the way we do it in Powershell) is to only ever load the "child" in an appdomain with its own dependencies, thus avoiding potential for conflict. But implementing this would mean re-working huge parts of CLI commands.

@natemcmaster
Copy link
Contributor Author

cc @rowanmiller @divega

@natemcmaster
Copy link
Contributor Author

Ping for review.

@divega
Copy link
Contributor

divega commented May 9, 2016

LGTM, but let's chat and find out if others are ok with the trade offs.

@natemcmaster natemcmaster deleted the namc/where-is-startup branch May 9, 2016 18:24
@natemcmaster
Copy link
Contributor Author

Closed. Let's solve this right rather than workaround limitations. #5311

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants