Decouple dotnet-ef from the framework #4977
Conversation
| @@ -51,7 +50,8 @@ public static int Main([NotNull] string[] args) | |||
| ex = ex.InnerException; | |||
| } | |||
|
|
|||
| if (!(ex is OperationException)) | |||
| if (!(ex is CommandException | |||
| || (ex as OperationException)?.Type == "Microsoft.EntityFrameworkCore.Design.OperationException")) | |||
There was a problem hiding this comment.
Should this be Microsoft.EntityFramework.Commands.OperationException?
There was a problem hiding this comment.
I think this is correct. I'll rename some of the types in Commands, so it's less confusing. (currently there are two OperationException and OperationExecutor types)
Rename things
|
I've bashed on it and things look OK. 83e510f needs review. Unfortunately, I get the following errors when using the tool with portable apps. 😞 Everything (except #4953) appears to be working with standalone apps.
|
Possible related to other "portable with native" errors? cref https://github.com/dotnet/cli/issues/1940 |
|
Don't forget to update csproj |
|
I want to say |
, but we should probably first make sure CLI is aware that tools on portable apps w/ native doesn't work.
|
Will file a bug, but these issues may no longer be relevant after we resolve #4577. |
|
ok. As long as dotnet-ef is working on something, this is improvement, right? |
lol, yes. We've gone from "not working" to "almost working" 😉 |
Part of #3925, also resolves #4837
@natemcmaster