Commands: Inject IHostingEnvironment, IApplicationEnvironment, etc. into Startup #4733
Conversation
| @@ -37,7 +37,7 @@ public static void Configure([NotNull] CommandLineApplication command) | |||
| "-o|--output-dir <path>", | |||
| "Directory of the project where the classes should be output. If omitted, the top-level project directory is used."); | |||
| var schemas = command.Option( | |||
| "-s|--schema <schema>", | |||
| "--schema <schema>", | |||
There was a problem hiding this comment.
@bricelam This is OK for now if you need to get this in. But I'd prefer to come up with a new short-form for --schema. It's odd that --table still has one but --schema does not.
There was a problem hiding this comment.
This was the fix we decided on in triage. You can create a new issue if you think it's common enough to deserve a short name. Personally, I think we should remove even more short names.
There was a problem hiding this comment.
If table is going to be more commonly used than schema then I think having a short name for table makes sense and I don't think we need symmetry between table and schema. Otherwise I think we should reassess.
There was a problem hiding this comment.
Personally, I think we should remove even more short names.
Agreed, I think we've gone a little overboard with them. To me they are most useful when you type by hand a lot (-verbose etc.). I imagine things like table/schema/etc. will generally be stored in a script etc.
There was a problem hiding this comment.
I think users will find the lack of symmetry odd. But I'm OK if we wait and see. It will be easy to add some abbreviation back in if we find it's wanted. Since we have no exclusion syntax, I do expect that the average number of -t|--tables on the command line will exceed the number of --schemas, sometimes significantly.
|
What's the override route for the case when you have custom services (from |
|
@NTaylorMullen We'll sort that out as part of #4546. Skipping |
|
|
Other small changes
OperationHandlers.csfor easier debugging--schema(fixes CLI Commands:dbcontext scaffoldhas two -s options #4677)#if DNX451project.json@NTaylorMullen This is the PR you're looking for... 👋
Part of #3925