Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI Commands: Fix design-time assembly resolution #4630

Merged
merged 2 commits into from
Feb 24, 2016
Merged

CLI Commands: Fix design-time assembly resolution #4630

merged 2 commits into from
Feb 24, 2016

Conversation

bricelam
Copy link
Contributor

Resolves #3925

Provider writers beware, this splits DesignTimeProviderServicesAttribute.FullyQualifiedTypeName into TypeName and AssemblyName. (cc @rowanmiller)

This should also fix #3862

@lajones
Copy link
Contributor

lajones commented Feb 23, 2016

:shipit: But maybe talk to @ajcvickers first - he raised #3111 which was to do the opposite and combine TypeName and AssemblyName.

@bricelam
Copy link
Contributor Author

The choices were...

I went with the simplest option. 😉 I'll bring it up in triage.

@ErikEJ
Copy link
Contributor

ErikEJ commented Feb 24, 2016

@bricelam Does this mean I should strong sign the SQL CE provider?

@bricelam bricelam merged commit c1fac5b into dotnet:dev Feb 24, 2016
@bricelam bricelam deleted the load branch February 24, 2016 21:51
@bricelam
Copy link
Contributor Author

@ErikEJ No, it should still be optional.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants