CLI Commands: Automatically build the project #4602
Conversation
| Reporter.Verbose.WriteLine("Build started...".Bold().Black()); | ||
|
|
||
| var buildCommand = Command.Create( | ||
| Path.Combine(Environment.GetEnvironmentVariable("DOTNET_HOME"), "bin", "dotnet" + Constants.ExeSuffix), |
There was a problem hiding this comment.
@davidfowl Good enough?
There was a problem hiding this comment.
Doh! DOTNET_HOME is being removed in dotnet/cli#1478
There was a problem hiding this comment.
Seems like we should raise an error if DOTNET_HOME is not defined?
There was a problem hiding this comment.
Sounds like we're going to assume it's on the path. (see dotnet/cli#1150) I'll update the PR.
| if (args[i] == "-v" || args[i] == "--verbose") | ||
| { | ||
| Environment.SetEnvironmentVariable(CommandContext.Variables.Verbose, bool.TrueString); | ||
| args = args.Take(i).Concat(args.Skip(i + 1)).ToArray(); |
There was a problem hiding this comment.
If you find a -v or --verbose at say, i = 4, then having re-calculated args wouldn't you need to start at i = 4 again in order to look at whatever was originally at i = 5 but now is at i = 4 instead of just carrying on with the i++ in the loop?
There was a problem hiding this comment.
The loop breaks after this. We find the first one, process and remove it, then stop
There was a problem hiding this comment.
OK. Sounds fine so long as if there are multiple -v or --verbose flags it doesn't cause some strange error later on.
There was a problem hiding this comment.
They're swallowed gracefully by the parser. 🍸
|
|
Part of #3925
Additional changes:
--verboseanywhere