Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Failing test and fix for: Subquery.Where(Expression<Func<Entity, bool>>) throws exception #4431

Merged
merged 4 commits into from
Feb 22, 2016
Merged

Failing test and fix for: Subquery.Where(Expression<Func<Entity, bool>>) throws exception #4431

merged 4 commits into from
Feb 22, 2016

Conversation

Tasteful
Copy link
Contributor

Failing test for #3722

@dnfclas
Copy link

dnfclas commented Jan 29, 2016

Hi @Tasteful, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution!
You've already signed the contribution license agreement. Thanks!

The agreement was validated by .NET Foundation and real humans are currently evaluating your PR.

TTYL, DNFBOT;

@Tasteful
Copy link
Contributor Author

If value of the evaluated parameter is an expression, use the expression instead of an expression-parameter that not can evaluated.

Fix for #3722

@Tasteful Tasteful changed the title Failing test for #3722 Failing test and fix for Subquery.Where(Expression<Func<Entity, bool>>) throws exception #3722 Jan 30, 2016
@Tasteful Tasteful changed the title Failing test and fix for Subquery.Where(Expression<Func<Entity, bool>>) throws exception #3722 Failing test and fix for: Subquery.Where(Expression<Func<Entity, bool>>) throws exception Jan 30, 2016
@Tasteful
Regression bug when same parametername is used
cade750 
if same parameter name is used in expression the SQL that is generated will use same table alias for the subquery.

As temporary fix I added an ISqlGenerator.GenerateAlias that create unique alias, see (code from RC1)
493234b
@Tasteful
Copy link
Contributor Author

Regression bug when same parametername is used
if same parameter name is used in expression the SQL that is generated will use same table alias for the subquery.

As temporary fix I added an ISqlGenerator.GenerateAlias that create unique alias (but query caching will not work so good), see (code from RC1)
Tasteful@cade750 but you probably have a better way to do that on :)

@anpete
Copy link
Contributor

anpete commented Feb 12, 2016

Blocked on #4537

@anpete anpete merged commit cade750 into dotnet:dev Feb 22, 2016
@Tasteful Tasteful deleted the bug3722 branch February 22, 2016 20:31
@mikary mikary mentioned this pull request Apr 27, 2016
Closed
@Tasteful Tasteful mentioned this pull request Jul 2, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@anpete anpete

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Tasteful @dnfclas @anpete @smitpatel