Allow complex boolean expressions in projection #4266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| public override void Select_ternary_operation_with_has_value_not_null() | ||
| { | ||
| // TODO: Optimize this query | ||
| base.Select_ternary_operation_with_has_value_not_null(); |
There was a problem hiding this comment.
filed #4267
Will also write it in comment.
smitpatel
force-pushed
the
HasValueNotNull
branch
from
1614f93 to
3da7993
Compare
| var test = Visit(node.Test); | ||
| _insideConditionalTest = false; |
There was a problem hiding this comment.
Does it matter if we re-enter here via nested conditionals?
There was a problem hiding this comment.
Case block inside When part (node.Test) is not supported. There can be nested conditionals inside IfTrue & IfFalse but not inside Test. So we do not enter VisitConditional while _insideConditionalTest is true.
Also added test for nested conditionals.
smitpatel
force-pushed
the
HasValueNotNull
branch
from
3da7993 to
a428217
Compare
|
Updated |
|
|
smitpatel
force-pushed
the
HasValueNotNull
branch
from
a428217 to
f1dd1ba
Compare
Apply nullsemantics to projection
smitpatel
force-pushed
the
HasValueNotNull
branch
from
f1dd1ba to
16dc210
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #2450
Removed all
context.Database.EnsureCreated/DeletedfromSeedmethod. All fixtures call Seed method after dropping/creating database.